Conversation
parthshrotri
left a comment
parthshrotri
left a comment
There was a problem hiding this comment.
Monte Carlo plots are still not showing data from multiple runs and 3sigma, DO NOT MERGE UNTIL FIXED
…ation seems to not work
rbhog
left a comment
rbhog
left a comment
There was a problem hiding this comment.
mainly code styling changes, will do another pass for functionality
| enable_direction_variance=atmo_args.get("enable_direction_variance", False), | ||
| enable_magnitude_variance=atmo_args.get("enable_magnitude_variance", False), | ||
| nominal_wind_magnitude=atmo_args.get("nominal_wind_magnitude", 0.0), | ||
| nominal_wind_direction=atmo_args.get("nominal_wind_direction", np.array([0, 0, 0]))) |
There was a problem hiding this comment.
probably better for the sake of standardization and legibility to have each of these fields explicitly defined in the dictionary before being passed in
|
|
||
| # Indices of each state variable in the output array | ||
| # kf and rkf values are arrays containing position, velocity and acceleration in each axis | ||
| indices = {"time":0, |
There was a problem hiding this comment.
also looking back, probably better to just have a global dataframe or smth to hold sim data because then we can access fields by property name and it's alr sorted by timestamps
| "kalman_raccel_z":60} | ||
|
|
||
| default_output_folder = 'Output' | ||
| def rmse(predictions, targets): |
| "launch_angle_mean": .00, | ||
| "launch_angle_stddev": 0.00} | ||
|
|
||
| monte(dt, kf_dt, samples, output_folder, target_size, **sim_params) No newline at end of file |
| "launch_angle_mean": .00, | ||
| "launch_angle_stddev": 0.00} | ||
|
|
||
| monte(dt, kf_dt, samples, output_folder, target_size, **sim_params) No newline at end of file |
There was a problem hiding this comment.
idk if out of scope but idt this code is thread safe so if we wanna ramp up number of runs in parallel we need to do that
2 participants
Restructured code into Configurations, Simulation core, executables, and output.
Cleaned up executing files.
Pysim can now be called by monte-python for Monte Carlo analysis
Monte-python now outputs to csv files