🎨 `docker-api-proxy` always requires authentication (⚠️devops) #7586

GitHK · 2025-04-25T11:05:22Z

What do these changes do?

Related issue/s

How to test

⚠️ Dev-ops checklist

No ENV changes or I properly updated ENV (read the instruction)
merge this MR before merging to MASTER
merge this MR during the release to STAGING
merge this MR during the release to PROD
Add configuration for new service docker-api-proxy osparc-ops-environments#965

codecov · 2025-04-25T11:07:04Z

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.77%. Comparing base (9d62136) to head (8bd38a3).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7586      +/-   ##
==========================================
+ Coverage   87.72%   87.77%   +0.04%     
==========================================
  Files        1771     1764       -7     
  Lines       68398    68203     -195     
  Branches     1135     1133       -2     
==========================================
- Hits        60005    59862     -143     
+ Misses       8079     8029      -50     
+ Partials      314      312       -2

Flag	Coverage Δ
integrationtests	`65.04% <ø> (+0.04%)`	⬆️
unittests	`86.96% <50.00%> (+0.03%)`	⬆️

Components	Coverage Δ
api	`∅ <ø> (∅)`
pkg_aws_library	`93.92% <ø> (ø)`
pkg_dask_task_models_library	`97.38% <ø> (ø)`
pkg_models_library	`92.73% <ø> (ø)`
pkg_notifications_library	`85.26% <ø> (ø)`
pkg_postgres_database	`88.27% <ø> (ø)`
pkg_service_integration	`69.92% <ø> (ø)`
pkg_service_library	`73.01% <0.00%> (+0.09%)`	⬆️
pkg_settings_library	`90.90% <100.00%> (ø)`
pkg_simcore_sdk	`85.72% <ø> (+0.05%)`	⬆️
agent	`96.46% <ø> (ø)`
api_server	`92.77% <ø> (ø)`
autoscaling	`96.08% <ø> (ø)`
catalog	`92.64% <ø> (ø)`
clusters_keeper	`99.25% <ø> (ø)`
dask_sidecar	`91.30% <ø> (ø)`
datcore_adapter	`98.12% <ø> (ø)`
director	`76.80% <ø> (ø)`
director_v2	`91.13% <ø> (+0.04%)`	⬆️
dynamic_scheduler	`97.40% <ø> (ø)`
dynamic_sidecar	`90.15% <ø> (ø)`
efs_guardian	`89.79% <ø> (ø)`
invitations	`93.28% <ø> (ø)`
payments	`92.66% <ø> (ø)`
resource_usage_tracker	`89.12% <ø> (ø)`
storage	`87.56% <ø> (+0.07%)`	⬆️
webclient	`∅ <ø> (∅)`
webserver	`86.03% <ø> (-0.03%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d62136...8bd38a3. Read the comment docs.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ic-auth-to-docker-api-proxy

services/docker-api-proxy/docker/boot.sh

mrnicegyu11

thx!

pcrespov

Thx. Left some comments.

packages/pytest-simcore/src/pytest_simcore/docker_api_proxy.py

packages/service-library/src/servicelib/fastapi/docker.py

services/docker-api-proxy/docker/Caddyfile

services/docker-api-proxy/tests/integration/test_docker_api_proxy.py

sanderegg

thanks!

packages/pytest-simcore/src/pytest_simcore/docker_api_proxy.py

packages/settings-library/src/settings_library/docker_api_proxy.py

services/docker-api-proxy/Dockerfile

…ic-auth-to-docker-api-proxy

GitHK · 2025-04-28T09:04:30Z

@Mergifyio queue

mergify · 2025-04-28T09:04:38Z

queue

🛑 The pull request has been removed from the queue `default`

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

services/docker-api-proxy/docker/boot.sh

services/docker-api-proxy/docker/Caddyfile

YuryHrytsuk

Thanks.

I will look for IP Whitelisting options in Caddy before going ahead

services/docker-api-proxy/docker/Caddyfile

…ic-auth-to-docker-api-proxy

mergify · 2025-04-29T09:29:32Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

GitHK · 2025-04-29T09:33:38Z

@Mergifyio requeue

mergify · 2025-04-29T09:33:53Z

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request.

mergify · 2025-04-29T09:33:55Z

queue

🛑 The pull request has been removed from the queue `default`

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

mergify · 2025-04-29T09:34:00Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

GitHK · 2025-04-29T13:21:09Z

@Mergifyio requeue

mergify · 2025-04-29T13:21:16Z

requeue

✅ This pull request will be embarked automatically

The head sha of this pull request, 4d3f572, was never embarked in the merge queue.

But don't worry, Mergify will embark it automatically for you.

mergify · 2025-04-29T13:21:18Z

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d6deede

…ic-auth-to-docker-api-proxy

….com:GitHK/osparc-simcore-forked into pr-osparc-add-basic-auth-to-docker-api-proxy

sonarqubecloud · 2025-04-30T04:47:35Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

service always requires credentials now

4ac92b3

GitHK self-assigned this Apr 25, 2025

GitHK added this to the Pauwel Kwak milestone Apr 25, 2025

GitHK changed the title ~~🎨 docker-api-proxy always requires authentication now~~ 🎨 docker-api-proxy always requires authentication now (⚠️devops) Apr 25, 2025

Andrei Neagu added 2 commits April 25, 2025 13:23

Merge remote-tracking branch 'upstream/master' into pr-osparc-add-bas…

9e4e4f6

…ic-auth-to-docker-api-proxy

fixed broken tests

edbf301

GitHK changed the title ~~🎨 docker-api-proxy always requires authentication now (⚠️devops)~~ 🎨 docker-api-proxy always requires authentication (⚠️devops) Apr 25, 2025

GitHK marked this pull request as ready for review April 25, 2025 11:31

GitHK requested review from sanderegg, mrnicegyu11, YuryHrytsuk and pcrespov as code owners April 25, 2025 11:31

GitHK requested review from giancarloromeo, matusdrobuliak66 and bisgaard-itis April 25, 2025 11:31

giancarloromeo approved these changes Apr 25, 2025

View reviewed changes

mrnicegyu11 reviewed Apr 25, 2025

View reviewed changes

services/docker-api-proxy/docker/boot.sh Show resolved Hide resolved

mrnicegyu11 approved these changes Apr 25, 2025

View reviewed changes

pcrespov approved these changes Apr 25, 2025

View reviewed changes

sanderegg approved these changes Apr 27, 2025

View reviewed changes

packages/pytest-simcore/src/pytest_simcore/docker_api_proxy.py Outdated Show resolved Hide resolved

packages/settings-library/src/settings_library/docker_api_proxy.py Show resolved Hide resolved

services/docker-api-proxy/Dockerfile Outdated Show resolved Hide resolved

Andrei Neagu added 5 commits April 28, 2025 10:55

feedback

4bc91ef

using long arguments

da283fd

using predefined code

b9e6764

Merge remote-tracking branch 'upstream/master' into pr-osparc-add-bas…

360b4c8

…ic-auth-to-docker-api-proxy

remove unused

cb7b3a1

GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 28, 2025

YuryHrytsuk reviewed Apr 28, 2025

View reviewed changes

services/docker-api-proxy/docker/boot.sh Show resolved Hide resolved

YuryHrytsuk reviewed Apr 28, 2025

View reviewed changes

services/docker-api-proxy/docker/Caddyfile Outdated Show resolved Hide resolved

YuryHrytsuk requested changes Apr 28, 2025

View reviewed changes

services/docker-api-proxy/docker/Caddyfile Show resolved Hide resolved

YuryHrytsuk self-requested a review April 29, 2025 06:21

YuryHrytsuk approved these changes Apr 29, 2025

View reviewed changes

Andrei Neagu added 2 commits April 29, 2025 10:06

typo

4c12f77

Merge remote-tracking branch 'upstream/master' into pr-osparc-add-bas…

c2817d9

…ic-auth-to-docker-api-proxy

matusdrobuliak66 approved these changes Apr 29, 2025

View reviewed changes

Andrei Neagu added 3 commits April 29, 2025 10:48

fixed tests

1bc4109

refactor

917b9e8

minor

522c336

Merge branch 'master' into pr-osparc-add-basic-auth-to-docker-api-proxy

4d3f572

Andrei Neagu added 3 commits April 30, 2025 06:40

fixed ci issues

1ddb1fb

Merge remote-tracking branch 'upstream/master' into pr-osparc-add-bas…

b226b2b

…ic-auth-to-docker-api-proxy

Merge branch 'pr-osparc-add-basic-auth-to-docker-api-proxy' of github…

8bd38a3

….com:GitHK/osparc-simcore-forked into pr-osparc-add-basic-auth-to-docker-api-proxy

mergify bot merged commit d6deede into ITISFoundation:master Apr 30, 2025
93 of 94 checks passed

GitHK deleted the pr-osparc-add-basic-auth-to-docker-api-proxy branch April 30, 2025 05:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎨 `docker-api-proxy` always requires authentication (⚠️devops) #7586

🎨 `docker-api-proxy` always requires authentication (⚠️devops) #7586

GitHK commented Apr 25, 2025 •

edited

Loading

codecov bot commented Apr 25, 2025 •

edited

Loading

mrnicegyu11 left a comment

pcrespov left a comment

sanderegg left a comment

GitHK commented Apr 28, 2025

mergify bot commented Apr 28, 2025 •

edited

Loading

YuryHrytsuk left a comment

mergify bot commented Apr 29, 2025

GitHK commented Apr 29, 2025

mergify bot commented Apr 29, 2025

mergify bot commented Apr 29, 2025 •

edited

Loading

mergify bot commented Apr 29, 2025

GitHK commented Apr 29, 2025

mergify bot commented Apr 29, 2025

mergify bot commented Apr 29, 2025 •

edited

Loading

sonarqubecloud bot commented Apr 30, 2025

🎨 docker-api-proxy always requires authentication (⚠️devops) #7586

🎨 docker-api-proxy always requires authentication (⚠️devops) #7586

Conversation

GitHK commented Apr 25, 2025 • edited Loading

What do these changes do?

Related issue/s

How to test

⚠️ Dev-ops checklist

codecov bot commented Apr 25, 2025 • edited Loading

Codecov Report

mrnicegyu11 left a comment

Choose a reason for hiding this comment

pcrespov left a comment

Choose a reason for hiding this comment

sanderegg left a comment

Choose a reason for hiding this comment

GitHK commented Apr 28, 2025

mergify bot commented Apr 28, 2025 • edited Loading

🛑 The pull request has been removed from the queue default

YuryHrytsuk left a comment

Choose a reason for hiding this comment

mergify bot commented Apr 29, 2025

GitHK commented Apr 29, 2025

mergify bot commented Apr 29, 2025

✅ This pull request will be re-embarked automatically

mergify bot commented Apr 29, 2025 • edited Loading

🛑 The pull request has been removed from the queue default

mergify bot commented Apr 29, 2025

GitHK commented Apr 29, 2025

mergify bot commented Apr 29, 2025

✅ This pull request will be embarked automatically

mergify bot commented Apr 29, 2025 • edited Loading

✅ The pull request has been merged automatically

sonarqubecloud bot commented Apr 30, 2025

Quality Gate passed

🎨 `docker-api-proxy` always requires authentication (⚠️devops) #7586

🎨 `docker-api-proxy` always requires authentication (⚠️devops) #7586

GitHK commented Apr 25, 2025 •

edited

Loading

codecov bot commented Apr 25, 2025 •

edited

Loading

mergify bot commented Apr 28, 2025 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented Apr 29, 2025 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented Apr 29, 2025 •

edited

Loading