🎨 add Postgres connection to dynamic-scheduler
#7600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 25, 2025 15:11
…gres-tables-to-dyamic-scheduler
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7600 +/- ##
==========================================
+ Coverage 87.73% 87.78% +0.04%
==========================================
Files 1784 1779 -5
Lines 68854 68720 -134
Branches 1133 1133
==========================================
- Hits 60411 60327 -84
+ Misses 8131 8081 -50
Partials 312 312
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
1 task
…gres-tables-to-dyamic-scheduler
GitHK
requested review from
sanderegg,
mrnicegyu11,
YuryHrytsuk and
pcrespov
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR connects Postgres to the dynamic-scheduler service and introduces the ProjectNetworks repository. Key changes include:
- Injecting Postgres lifespan and connection details in tests and configuration.
- Adding repository logic for handling project networks.
- Updating CLI and docker-compose files to support new Postgres settings.
Reviewed Changes
Copilot reviewed 24 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/dynamic-scheduler/tests/unit/service_tracker/test__api.py | Added disable_postgres_lifespan parameter to the fixture |
| services/dynamic-scheduler/tests/unit/api_rpc/test_api_rpc__services.py | Added disable_postgres_lifespan parameter in RPC client fixture |
| services/dynamic-scheduler/tests/unit/api_rest/test_api_rest__meta.py | Renamed test function from test_health to test_meta for clarity |
| services/dynamic-scheduler/tests/unit/api_rest/conftest.py | Added Postgres lifespan disable parameter |
| services/dynamic-scheduler/tests/unit/api_frontend/*.py | Added "postgres" to core services selection lists |
| services/dynamic-scheduler/tests/unit/api_frontend/conftest.py | Added Postgres configuration fixtures for frontend tests |
| services/dynamic-scheduler/tests/conftest.py | Added Postgres service and updated event patching configuration (note duplicate fixture entry) |
| services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/repository/project_networks.py | Introduced repository and error classes for project networks (typo in error class name) |
| services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/repository/events.py | Registered the new repository lifespan manager |
| services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/settings.py | Added Postgres settings configuration |
| services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/events.py | Included repository lifespan in app startup |
| services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/cli.py | Updated CLI to handle new Postgres configuration |
| services/docker-compose.yml | Added Postgres environment variables to the service configuration |
| packages/service-library/src/servicelib/logging_utils.py | Updated logging calls with a stacklevel parameter |
Files not reviewed (4)
- services/dynamic-scheduler/requirements/_test.in: Language not supported
- services/dynamic-scheduler/requirements/_test.txt: Language not supported
- services/dynamic-scheduler/requirements/_tools.txt: Language not supported
- services/dynamic-scheduler/setup.cfg: Language not supported
Comments suppressed due to low confidence (1)
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/repository/project_networks.py:14
- There is a typo in the class name 'BaseProjectNetwroksError'. It should be 'BaseProjectNetworksError' to maintain consistent naming.
class BaseProjectNetwroksError(OsparcErrorMixin, RuntimeError):
YuryHrytsuk
approved these changes
Apr 29, 2025
added 3 commits
April 29, 2025 09:52
sanderegg
approved these changes
Apr 29, 2025
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/repository/project_networks.py
Show resolved
Hide resolved
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/repository/project_networks.py
Show resolved
Hide resolved
matusdrobuliak66
approved these changes
Apr 29, 2025
giancarloromeo
approved these changes
Apr 29, 2025
pcrespov
approved these changes
Apr 29, 2025
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/settings.py
Outdated
Show resolved
Hide resolved
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/repository/events.py
Show resolved
Hide resolved
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/repository/project_networks.py
Show resolved
Hide resolved
added 2 commits
April 30, 2025 07:31
|
@Mergifyio queue |
🟠 Waiting for conditions to match
|
added 3 commits
April 30, 2025 11:21
|
pcrespov
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Connects
Postgrestodynamic-schedulerand also adds theProjectNetowrksrepository.Related issue/s
How to test
Dev-ops checklist