Skip to content

Conversation

brokentone
Copy link
Contributor

A divergence was introduced here between the package file and the package lock file: #145

This PR simply syncs the package-lock.json file back with the new project expectations.

@IanVS
Copy link
Owner

IanVS commented Oct 16, 2025

I'm glad you brought this up. I'm surprised that npm ci in the CI job of that PR didn't flag the failure. So I went to look, and unfortunately it seems like sure enough it didn't block the installation (https://github.com/IanVS/eslint-nibble/actions/runs/18406068966/job/52446178330?pr=145) It seems I just misunderstood what npm ci would fail on, and this is expected: npm/cli#7464.

Worse still, we accidentally introduced a new dependency that requires node 20+ (https://github.com/sindresorhus/terminal-link/releases/tag/v5.0.0).

I think we need to downgrade that dependency to 4.0.0 so that we can maintain node.js 18+ support. Would you be willing to do that, @brokentone?

@brokentone
Copy link
Contributor Author

@IanVS oof -- sorry about that. Happy to take it on, maybe I'll just remove the package? I believe that terminal linking functionality has extremely limited support anyway (verses colors which have significant support)

@IanVS
Copy link
Owner

IanVS commented Oct 16, 2025

Sure, that would be fine too, I'll leave it up to you.

I also realized we should probably update the screenshot(s?) in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants