Shutdown Context and Fixes #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to a signal based context which is being canceled for SIGINT and SIGTERM. This change was extracted from the ongoing PR #112.
julianbrost
requested changes
Nov 2, 2023
The break only broke out of the select, but continued the for loop.
Allow gracefully stopping the internal web server when the parent context is closed.
julianbrost
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works on the initial signal-based context changes from #112. During testing I found my Icinga Notifications container always being stuck when being shut downed until it got SIGKILLed. Thus, next to the introduction of the signal context, a context bug in the
RuntimeConfigwas fixed and a simple context wrapper was added to theListener.Allow gracefully stopping the internal web server when the parent context is closed.
The break only broke out of the select, but continued to for loop.
Switch to a signal based context which is being canceled for SIGINT and SIGTERM. This change was extracted from the ongoing PR Icinga 2 API as Event Source #112.