Use utils.IterateOrderedMap() as intended, via for:=range (require Go 1.23)#276
Merged
Use utils.IterateOrderedMap() as intended, via for:=range (require Go 1.23)#276
Conversation
ef004d8 to
722b6ae
Compare
Member
Author
Dev's platforms w/ Go 1.23
|
Member
|
Thanks for the roadmap. Just for your information, Go 1.23 is already available in the nixpkgs, just not under the https://search.nixos.org/packages?channel=unstable&show=go_1_23 |
oxzi
reviewed
Apr 16, 2025
Member
oxzi
left a comment
There was a problem hiding this comment.
Please remove the change to the go.mod and rebase.
722b6ae to
176abc6
Compare
176abc6 to
ac235b7
Compare
Member
The rebase I requested is required to get this running. I have rebased this PR for you and would merge it unless the CI is going to fail now. |
oxzi
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.