Skip to content

Fix fields shoud not be added if empty#2947

Open
moreamazingnick wants to merge 1 commit intoIcinga:masterfrom
RISE-GmbH:fix/fields-should-not-be-added-if-empty-#2945
Open

Fix fields shoud not be added if empty#2947
moreamazingnick wants to merge 1 commit intoIcinga:masterfrom
RISE-GmbH:fix/fields-should-not-be-added-if-empty-#2945

Conversation

@moreamazingnick
Copy link
Copy Markdown
Contributor

@moreamazingnick moreamazingnick commented Jan 3, 2025

This is properly not the best fix but since a host is basically the same objecttype as a hosttemplate and a host template has fields but a host has not this is the best I could come up with.

Best Regards
Nicolas

fixes #2945

@cla-bot cla-bot bot added the cla/signed label Jan 3, 2025
@moreamazingnick
Copy link
Copy Markdown
Contributor Author

@lippserd

@lippserd lippserd changed the title Fix fields shoud not be added if empty refs #2945 Fix fields shoud not be added if empty Jan 7, 2026
@lippserd lippserd requested a review from raviks789 January 7, 2026 09:02
Copy link
Copy Markdown
Collaborator

@raviks789 raviks789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a complete resolution. This will still not resolve updating of templates through cli commands or Rest API, if the exported data is being used to update them. As the exporter will still add the 'fields' property in these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

icingacli error with modify action - Trying to set invalid key "fields"

2 participants