Conversation
Requirements are already validated during module activation, making a post-activation dependency check redundant. Additionally, starting with version 1.12, Icinga Director depends on the icinga-php-legacy library rather than the incubator module, eliminating the risk of accidentally deactivating the incubator module while Icinga Director is active.
PHP 5.* is not supported any more by Icinga Director and hence it is redundant to check the compatibility with the corresponding version
raviks789
force-pushed
the
remove-dependency-checker
branch
from
31b4604 to
71d39d7
Compare
nilmerg
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant missing dependency check and the PHP legacy compatibility checks once the module requires icinga-php-legacy instead of incubator module.
Depends on: requirements to be updated to use icinga-php-legacy library