Clone attributes #110
Merged
Clone attributes #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See Icinga/ipl-web#104 for the duplicate submit button PR and #96 for proper cloning. |
lippserd
force-pushed
the
clone-attributes
branch
2 times, most recently
from
528b019 to
fbb3dd8
Compare
lippserd
force-pushed
the
clone-attributes
branch
from
fbb3dd8 to
8845172
Compare
Added my own test. The PR referenced contains two tests that basically do the same thing, but only change one attribute. Here we also test adding and removing attributes and cloning already cloned attributes. |
nilmerg
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have an attribute cloning use case where we duplicate the primary submit button and add it as the first element to ensure that it is used for implicit form submission. The submit button to be cloned can have attributes and callbacks that must also be present on the clone, such as
formaction,formmethodandformnovalidate, so simply not using the original attributes is not an option.Until proper cloning is implemented, it is imperative to re-register attribute callbacks for attributes where a callback exists and the clone provides a changed value.