feat(carousel): improve carousel theme and add missed properties#15525
Merged
simeonoff merged 4 commits intodidimmova/improve-component-themesfrom Apr 25, 2025
Merged
Conversation
didimmova
added
🎠 carousel
❌ status: awaiting-test
…es' into didimmova/improve-carousel-theme
SisIvanova
requested changes
Apr 17, 2025
| $meta: map.get($theme, '_meta'); | ||
| $variant: map.get($theme, '_meta', 'theme'); | ||
|
|
||
| @if $variant == 'indigo' { |
Collaborator
There was a problem hiding this comment.
You have multiple checks if the theme is indigo that can be combined into one.
SisIvanova
added
✅ status: verified
SisIvanova
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15494
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)