-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GridBase): Apply spec for server-side rendering for relative gri… #15556
base: master
Are you sure you want to change the base?
Conversation
FYI, the grid will now retain 100% size (width/height) from the SSR render, however note that things inside the grid may still flicker during hydration on the client. For example:
|
@MayaKirova If you have a grid width a fixed sizes ( let say 600px width and height) then the data should be rendered on the server but it doesnt. It renders on the client |
return !this.platform.isBrowser && this.isPercentHeight ? undefined : this.data; | ||
} | ||
|
||
@HostBinding('style.display') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't those host bindings be in the scss in the themes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They already are (you can find the same styles in the theme), but they don't get applied until the theme is fully loaded and they are necessary for the body content to stretch correctly in SSR. Hence why they are set inline as well.
…d sizes.
Closes #15202
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)