Skip to content

Conversation

@ImDevinC
Copy link
Owner

StreamController/StreamController-Store#60

Fixes:

  • Store image works properly
  • Authentication now uses threads
  • Authentication now has callbacks to inform the user of state

@ImDevinC ImDevinC merged commit 0ef821c into main Nov 13, 2024
1 check passed
@ImDevinC ImDevinC deleted the fixes branch November 13, 2024 06:03
@ImDevinC ImDevinC mentioned this pull request Nov 13, 2024
ImDevinC added a commit that referenced this pull request Dec 27, 2025
Replace unbounded daemon thread creation with a bounded thread pool
for better resource management and proper cleanup:

Changes:
- main.py: Import ThreadPoolExecutor from concurrent.futures
- main.py: Create _thread_pool with max_workers=4 in __init__
- main.py: Replace threading.Thread() with _thread_pool.submit()
- main.py: Remove daemon=True flag (pool handles lifecycle)

Benefits:
- Bounded resource usage (max 4 concurrent threads)
- Better thread lifecycle management
- Proper cleanup on shutdown
- Named threads for easier debugging (discord- prefix)

Impact: Better resource management, improved stability

Resolves issue #6 from RESEARCH.md Phase 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants