ENH: stricter handling of empty comment lines in description parsers#127
Merged
ENH: stricter handling of empty comment lines in description parsers#127
Conversation
Table description parser now stops collecting at an empty comment line (bare `#`), so only the actual description is captured. Column description parser raises ValueError if an empty comment line appears inside a `# description:` block, catching accidental paragraph breaks early. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#alone) now stops collection, so only the actual description text is captured (e.g., excludes "Approach overview" section involume_geometry_index.sql)# description:block now raisesValueErrorwith line number, catching accidental paragraph breaks earlyTest plan
test_empty_description_linesupdated to assertValueErroris raised🤖 Generated with Claude Code