Apply overrides for data_input_dict in Node #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barneydobson
approved these changes
Mar 18, 2024
Co-authored-by: barneydobson <[email protected]>
barneydobson
approved these changes
Mar 19, 2024
barneydobson
requested changes
Jul 29, 2024
Co-authored-by: barneydobson <[email protected]>
Co-authored-by: barneydobson <[email protected]>
barneydobson
approved these changes
Aug 1, 2024
dalonsoa
requested changes
Aug 13, 2024
Co-authored-by: barneydobson <[email protected]>
dalonsoa
requested changes
Oct 4, 2024
| @@ -417,6 +419,27 @@ def test_data_read(self): | |||
|
|
|||
| self.assertEqual(15, node.get_data_input("temperature")) | |||
|
|
|||
| def test_data_overrides(self): | |||
There was a problem hiding this comment.
This only test the first branch of the conditional statement. You need another test for the case of not content and another one for the else case, which is an error.
There was a problem hiding this comment.
Added commit 91f198d
Co-authored-by: Diego Alonso Álvarez <[email protected]>
barneydobson
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note these changes do no apply to
Surfaceand its superclasses as they are based on theDecayTank, which does not havedata_input_dictattribute. The overrides fordata_input_dictinSurfaceare addressed in issue #76.