Skip to content

Improve Digital Bid Adapter: Added support for MultiBid #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubomirshishkov merged 2 commits into from
Feb 18, 2025
Merged

Improve Digital Bid Adapter: Added support for MultiBid #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1d2947
## FMSC-1894 - Add support for MultiBid in Improve Digital's Prebid B…
lyubomirshishkov Feb 12, 2025
44c2250
* modified `CONVERTER.imp method` to use `bidderRequest.bidLimit`, in…
lyubomirshishkov Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/improvedigitalBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ export const CONVERTER = ortbConverter({
}
deepSetValue(imp, `${bidderParamsPath}.keyValues`, getBidIdParameter('keyValues', bidRequest.params) || undefined);

context.bidderRequest.bidLimit && deepSetValue(imp, 'ext.max_bids', context.bidderRequest.bidLimit);

return imp;
},
request(buildRequest, imps, bidderRequest, context) {
Expand Down
22 changes: 22 additions & 0 deletions test/spec/modules/improvedigitalBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,28 @@ describe('Improve Digital Adapter Tests', function () {
expect(payload.imp[0].ext.prebid.storedrequest.id).to.equal('123456');
});

it('should add max_bids param in imp.ext objects when bidLimit is specified in the bidderRequest', function () {
const bidderRequestDeepClone = deepClone(bidderRequest);
bidderRequestDeepClone.bidLimit = 3;
const requests = spec.buildRequests([simpleBidRequest, instreamBidRequest], bidderRequestDeepClone);
// banner
let payload = JSON.parse(requests[0].data);
expect(payload.imp[0].ext.max_bids).to.equal(3);
// video
payload = JSON.parse(requests[1].data);
expect(payload.imp[0].ext.max_bids).to.equal(3);
});

it('should not add max_bids param in imp.ext objects when bidLimit is not specified in the bidderRequest', function () {
const requests = spec.buildRequests([simpleBidRequest, instreamBidRequest], bidderRequest);
// banner
let payload = JSON.parse(requests[0].data);
expect(payload.imp[0].ext.max_bids).to.not.exist;
// video
payload = JSON.parse(requests[1].data);
expect(payload.imp[0].ext.max_bids).to.not.exist;
});

it('should set extend url when extend mode enabled in adunit params', function () {
const bidRequest = deepClone(extendBidRequest);
let request = spec.buildRequests([bidRequest], { bids: [bidRequest] })[0];
Expand Down