Ghosh

[Kajwan]

See TODO.md for work that is still to be done.

[coveralls]

Pull Request Test Coverage Report for Build 18010829368

Details

• 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 87.243%

---

Totals
Change from base Build 16325450683:	0.0%
Covered Lines:	2626
Relevant Lines:	3010

---

💛 - Coveralls

[Beckebanze]

I looked through the changes in this PR. Everything is clear.

One important point: Please add in the version release that will include this PR that the definition of G has changed. As and M_down are also changed, but they are also renamed to B and M_Ghosh, respectively, meaning that there is no risk of any code utilizing pymrio to take over the changes unnoticeable. However, as G changed definition but not the object name this could go unnoticed with switching to a new pymrio-version. We have code that does make use of the old definition of G, which will require a few changes to the implementation.

On my side, I will make sure that we switch to the new pymrio version that includes this PR as an organization in one go, rewriting our code that makes use of the previous definition of G and ensuring that older pymrio versions cannot be used thereafter.