feat: New view iPadOS #1468
Open
feat: New view iPadOS #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaptGrv
force-pushed
the
feat/newView-iPadOS18
branch
from
8800531 to
8fd9dff
Compare
adrien-coye
requested changes
Mar 27, 2025
| } | ||
|
|
||
| @objc func buttonMenuClicked(_ sender: UIBarButtonItem) { | ||
| if selectedIndexPath != [-1, -1] { |
There was a problem hiding this comment.
You could make a named const out of this [-1, -1]
You might also want to consider put this if … logic behind a var -> Bool
| let documentPicker = DriveImportDocumentPickerViewController(forOpeningContentTypes: [UTType.data], asCopy: true) | ||
| documentPicker.importDrive = driveFileManager.drive | ||
| documentPicker.importDriveDirectory = currentDirectory.freezeIfNeeded() | ||
| documentPicker.delegate = mainTabViewController | ||
| // documentPicker.delegate = mainTabViewController |
There was a problem hiding this comment.
Probably something to do here, or to clean
PhilippeWeidmann
force-pushed
the
feat/newView-iPadOS18
branch
from
9dff760 to
20d515a
Compare
# Conflicts: # Tuist/ProjectDescriptionHelpers/Constants.swift
# Conflicts: # kDrive/UI/Controller/Create File/PlusButtonFloatingPanelViewController.swift
# Conflicts: # Tuist/Package.resolved # Tuist/Package.swift
# Conflicts: # kDrive/UI/Controller/Files/SidebarViewController.swift
BaptGrv
force-pushed
the
feat/newView-iPadOS18
branch
from
6b3548f to
18d6744
Compare
adrien-coye
force-pushed
the
feat/newView-iPadOS18
branch
from
18d6744 to
f23fd6f
Compare
adrien-coye
reviewed
Apr 15, 2025
| return | ||
| } | ||
|
|
||
| guard let previousDriveId = sceneUserInfo[SceneRestorationValues.driveId.rawValue] as? Int, |
There was a problem hiding this comment.
We need to re-enable app state restoration before we can merge this branch. I'll brief you up 👍
This reverts commit 5fcff7b.
# Conflicts: # kDrive/UI/Controller/Files/SidebarViewController.swift
adrien-coye
force-pushed
the
feat/newView-iPadOS18
branch
from
f23fd6f to
22e9d92
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.