Skip to content

feat: New view iPadOS #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 63 commits into from
May 28, 2025
Merged

feat: New view iPadOS #1468

merged 63 commits into from
May 28, 2025

Conversation

BaptGrv
Copy link
Contributor

@BaptGrv BaptGrv commented Mar 7, 2025

No description provided.

@BaptGrv BaptGrv force-pushed the feat/newView-iPadOS18 branch from 8800531 to 8fd9dff Compare March 26, 2025 14:07
@adrien-coye adrien-coye self-requested a review March 26, 2025 14:43
@adrien-coye adrien-coye added the feature A new functionality is added to the product label Mar 26, 2025
@adrien-coye adrien-coye added this to the 5.4.0 milestone Mar 26, 2025
adrien-coye
adrien-coye previously requested changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a first review. Code looks good 👍

I played with it on iPad and iPhone, the iPad is promising, the iPhone needs some changes.

I'll DM you more in details my findings.

@adrien-coye adrien-coye modified the milestones: 5.4.0, 5.5.0 Apr 7, 2025
@BaptGrv BaptGrv force-pushed the feat/newView-iPadOS18 branch from 6b3548f to 18d6744 Compare April 15, 2025 11:42
@adrien-coye adrien-coye force-pushed the feat/newView-iPadOS18 branch from 18d6744 to f23fd6f Compare April 15, 2025 14:37
adrien-coye
adrien-coye reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the branch today, the UI looks good both on iPhone and iPad. Good job.

One detail remains before we can merge this branch.
We need to re-enable state restoration, I'll brief you up.

@adrien-coye adrien-coye force-pushed the feat/newView-iPadOS18 branch from f23fd6f to 22e9d92 Compare April 15, 2025 15:03
@BaptGrv BaptGrv force-pushed the feat/newView-iPadOS18 branch from a961835 to 0db96eb Compare April 28, 2025 12:48
adrien-coye
adrien-coye reviewed Apr 29, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did re-review this branch.
iOS 15 is now working, also state restoration is OK.
I leave it to @PhilippeWeidmann to test this branch. Let me know before merging.

adrien-coye
adrien-coye reviewed May 1, 2025
View reviewed changes
@BaptGrv BaptGrv force-pushed the feat/newView-iPadOS18 branch from c320588 to a8b6370 Compare May 1, 2025 06:52
@adrien-coye
Copy link
Contributor

adrien-coye commented May 2, 2025 •
edited
Loading

Discussed : Check that actions like upload media / take picture works on iPad

@BaptGrv BaptGrv force-pushed the feat/newView-iPadOS18 branch 3 times, most recently from 4577883 to 100eafd Compare May 13, 2025 12:57
@adrien-coye adrien-coye modified the milestones: 5.5.0, 5.6.0 May 13, 2025
adrien-coye
adrien-coye reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a code review. I only found some minor details. I'll check on device tomorrow.

adrien-coye
adrien-coye reviewed May 14, 2025
View reviewed changes
@adrien-coye
Copy link
Contributor

I did some in depth testing of the app on both platforms this morning.

@BaptGrv BaptGrv force-pushed the feat/newView-iPadOS18 branch 3 times, most recently from 2eea56f to 001d7e2 Compare May 19, 2025 11:07
@PhilippeWeidmann PhilippeWeidmann force-pushed the feat/newView-iPadOS18 branch from f2ca306 to 98744eb Compare May 20, 2025 12:31
BaptGrv and others added 22 commits May 28, 2025 14:24
@BaptGrv @dev-mobile-bot
fix: SwiftLint
0dc0abf
@BaptGrv @dev-mobile-bot
fix: Show offline and download sections only once on top
6f3051c
@adrien-coye @dev-mobile-bot
fix(CustomLargeTitleCollectionViewController): Failure to update navi…
c05ead8 
…gationItem.title on a rotation on iPad
@adrien-coye @dev-mobile-bot
refactor: Sharing the isCompactView logic
c7875ef
@BaptGrv @dev-mobile-bot
fix: Add guard to reduce indentation and use UIConstants
5d5dfda
@BaptGrv @dev-mobile-bot
fix: Can now present the right folder after a download
6dba767
@PhilippeWeidmann @dev-mobile-bot
fix: Ensure we get correct color for back button
541cbda 
Signed-off-by: Philippe Weidmann <[email protected]>
@BaptGrv @dev-mobile-bot
fix: Wrong var name
1b08227
@BaptGrv @dev-mobile-bot
fix: SwiftLint
431a487
@PhilippeWeidmann @dev-mobile-bot
refactor: Use UIButton.Configuration + update constraints
4cdacb1 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann @dev-mobile-bot
fix: Keep hiding navbar in menu
2c24738 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann @dev-mobile-bot
fix: More robust sidebar navigation
d94695b 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann @dev-mobile-bot
fix: Present menu modally
1a28a2b 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann @dev-mobile-bot
refactor: Separate snapshot code
2fbf646 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann @dev-mobile-bot
fix: Use new button APIs
7a842fe 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann @dev-mobile-bot
fix: Correctly set navigationBar tint
cc5b24d 
Signed-off-by: Philippe Weidmann <[email protected]>
@BaptGrv @dev-mobile-bot
fix: Add missing var photoPickerDelegate
d1f142a
@PhilippeWeidmann @dev-mobile-bot
fix: Correct RootMenuDestination hash value
c4268be 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann @dev-mobile-bot
fix: Hide floating panel before presenting MenuViewController
8ab153b 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann @dev-mobile-bot
fix: Correct plus button size
90de84f 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann @dev-mobile-bot
fix(PreviewViewController): Use compositional layout for correct sizing
c06a6c1 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann @dev-mobile-bot
feat: Use popover for plus button
42fa186 
Signed-off-by: Philippe Weidmann <[email protected]>
@github-actions github-actions bot removed the rebase label May 28, 2025
@github-actions github-actions bot force-pushed the feat/newView-iPadOS18 branch from f667acc to 582730b Compare May 28, 2025 14:24
@PhilippeWeidmann PhilippeWeidmann force-pushed the feat/newView-iPadOS18 branch from 582730b to 426ad2a Compare May 28, 2025 14:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@PhilippeWeidmann PhilippeWeidmann dismissed adrien-coye’s stale review May 28, 2025 14:40

Approved by message

@PhilippeWeidmann PhilippeWeidmann merged commit ad5bbe7 into master May 28, 2025
8 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the feat/newView-iPadOS18 branch May 28, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

@Lnamw Lnamw Awaiting requested review from Lnamw

@adrien-coye adrien-coye Awaiting requested review from adrien-coye

Assignees
No one assigned
Labels
feature A new functionality is added to the product
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@BaptGrv @adrien-coye @PhilippeWeidmann