Skip to content

fix(baseapp): metrics cardinality for PrepareProposal and ProcessProposal#81

Merged
maxim-inj merged 1 commit intov0.50.x-injfrom
fix-metrics-cardinality-2
Mar 7, 2026
Merged

fix(baseapp): metrics cardinality for PrepareProposal and ProcessProposal#81
maxim-inj merged 1 commit intov0.50.x-injfrom
fix-metrics-cardinality-2

Conversation

@kakysha
Copy link

@kakysha kakysha commented Mar 7, 2026

  • bump metrics/v2 version to fix panic with nil ctx

Summary by CodeRabbit

Release Notes

  • Refactor

    • Enhanced observability and diagnostics for proposal validation processes with improved tracing instrumentation. Provides better monitoring, debugging capabilities, and system visibility for operators.
  • Chores

    • Updated metrics library dependency to v2.0.0-beta.8 across all project modules for improved stability and consistent versioning.

…osal

+ bump metrics/v2 version to fix panic with nil ctx
@github-actions
Copy link

github-actions bot commented Mar 7, 2026

@kakysha your pull request is missing a changelog!

@coderabbitai
Copy link

coderabbitai bot commented Mar 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 251f187b-5f37-4c4c-9461-ce9364b71b97

📥 Commits

Reviewing files that changed from the base of the PR and between e8435e3 and 6c47cda.

⛔ Files ignored due to path filters (3)
  • go.sum is excluded by !**/*.sum
  • simapp/go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • baseapp/abci.go
  • go.mod
  • simapp/go.mod
  • tests/go.mod

📝 Walkthrough

Walkthrough

The changes update metrics instrumentation in ABCI handler methods to use trace tagging for height information and bump the metrics dependency version from beta.6 to beta.8 across go.mod files. No behavioral changes to control flow or error handling.

Changes

Cohort / File(s) Summary
Metrics Instrumentation
baseapp/abci.go
Replaced metrics.Tag("height", req.Height) with metrics.TraceTag("height", req.Height) in three defer statements within PrepareProposal and ProcessProposal methods to align timing instrumentation with tracing metadata.
Dependency Updates
go.mod, simapp/go.mod, tests/go.mod
Bumped github.com/InjectiveLabs/metrics/v2 from v2.0.0-beta.6 to v2.0.0-beta.8 across all go.mod files to pull in the latest metrics library improvements.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Metrics traced with care so bright,
Heights now tagged in tracing light,
Dependency bumps, beta steps ahead,
Instrumentation wisdom widely spread,

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating metrics tagging for PrepareProposal and ProcessProposal methods to use trace tagging instead of generic tagging.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-metrics-cardinality-2

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedcosmossdk.io/​tools/​confix@​v0.1.1100100100100100

View full report

@maxim-inj maxim-inj merged commit c294279 into v0.50.x-inj Mar 7, 2026
42 of 50 checks passed
@maxim-inj maxim-inj deleted the fix-metrics-cardinality-2 branch March 7, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants