fix(baseapp): metrics cardinality for PrepareProposal and ProcessProposal#81
Conversation
…osal + bump metrics/v2 version to fix panic with nil ctx
|
@kakysha your pull request is missing a changelog! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe changes update metrics instrumentation in ABCI handler methods to use trace tagging for height information and bump the metrics dependency version from beta.6 to beta.8 across go.mod files. No behavioral changes to control flow or error handling. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Summary by CodeRabbit
Release Notes
Refactor
Chores