fix: sync proto with indexer - remove status from RFQRequestInputType#3
fix: sync proto with indexer - remove status from RFQRequestInputType#3tajik-ninja wants to merge 1 commit intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA protobuf schema modification that removes the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Syncs the RFQ gRPC proto definitions with the referenced indexer change to prevent a client-controlled RFQ request status field.
Changes:
- Removed
statusfromRFQRequestInputType. - Renumbered
transaction_timewithinRFQRequestInputType.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uint64 expiry = 8; | ||
| // Status (open, cancelled, completed) | ||
| string status = 9; | ||
| // Transaction time timestamp | ||
| uint64 transaction_time = 10; | ||
| uint64 transaction_time = 9; |
There was a problem hiding this comment.
transaction_time was renumbered from field 10 to 9 after removing status. In protobuf, field numbers are part of the wire contract and should not be reused; this change will break backward/forward compatibility (old clients/servers will misinterpret or drop the field due to tag/type mismatch). Keep transaction_time = 10 and reserve field number 9 (and optionally the name status) to prevent accidental reuse.
Syncs with indexer commit cd282f4 (C-871) which fixed client-controlled status field.
Summary by CodeRabbit