-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up scripts for old website #391
Conversation
I remember there was something about tracing possible links in our videos that we'd need to keep active. Do we need to address this here too? |
I'm not sure about this - do you mean links referenced in the videos? If so, that would probably need a redirect/permalink set up in the new Hugo site. Happy to take a look, but would prefer raising as a separate issue. |
Why does it appear that we are making functional code changes, here? Is it just refactoring? |
Created #393 for this. |
Should just be a refactor, but it is quite a big one. I've pulled logic out of |
I'd like to review by actually trying this out but not sure exactly when I'll have time. |
No worries @rrrutledge, I don't think this is blocking anything right now so no rush. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I used it for InnerSourceCommons/innersourcecommons.org#115
Sounds like this could be ready to be used in GitHub actions for automation purposes? |
I think so - just need to wire it up. |
Note this has been branched from #390, so also contains those changes.#390 merged.