Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up scripts for old website #391

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Conversation

tsadler1988
Copy link
Collaborator

@tsadler1988 tsadler1988 commented Mar 31, 2021

Note this has been branched from #390, so also contains those changes. #390 merged.

@tsadler1988 tsadler1988 requested a review from a team as a code owner March 31, 2021 19:59
@tsadler1988 tsadler1988 changed the title New site live scripts cleanup Clean up scripts for old website Mar 31, 2021
@lenucksi
Copy link
Member

lenucksi commented Apr 1, 2021

I remember there was something about tracing possible links in our videos that we'd need to keep active. Do we need to address this here too?

@tsadler1988
Copy link
Collaborator Author

I remember there was something about tracing possible links in our videos that we'd need to keep active. Do we need to address this here too?

I'm not sure about this - do you mean links referenced in the videos? If so, that would probably need a redirect/permalink set up in the new Hugo site. Happy to take a look, but would prefer raising as a separate issue.

@rrrutledge
Copy link
Contributor

Why does it appear that we are making functional code changes, here? Is it just refactoring?

@lenucksi
Copy link
Member

lenucksi commented Apr 2, 2021

I remember there was something about tracing possible links in our videos that we'd need to keep active. Do we need to address this here too?

I'm not sure about this - do you mean links referenced in the videos? If so, that would probably need a redirect/permalink set up in the new Hugo site. Happy to take a look, but would prefer raising as a separate issue.

Created #393 for this.

@tsadler1988
Copy link
Collaborator Author

Why does it appear that we are making functional code changes, here? Is it just refactoring?

Should just be a refactor, but it is quite a big one. I've pulled logic out of generate_hugo_learning_path_markdown.js and put it into generate_learning_path_markdown.js, which might be why it looks like functional change.

@rrrutledge
Copy link
Contributor

I'd like to review by actually trying this out but not sure exactly when I'll have time.

@tsadler1988
Copy link
Collaborator Author

No worries @rrrutledge, I don't think this is blocking anything right now so no rush.

Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrrutledge rrrutledge merged commit e1be0ac into master Apr 29, 2021
@rrrutledge rrrutledge deleted the new-site-live-scripts-cleanup branch April 29, 2021 16:57
@lenucksi
Copy link
Member

lenucksi commented May 1, 2021

Sounds like this could be ready to be used in GitHub actions for automation purposes?

@rrrutledge
Copy link
Contributor

Sounds like this could be ready to be used in GitHub actions for automation purposes?

I think so - just need to wire it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants