-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page exclusive for pt-br content #14
Conversation
Here's my suggestion
What do you think? If you can agree on that, I will ad them as codeowners |
I agree, let's start with the most simple possible structure, and see how that works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
left minor formatting suggestions inline
Co-authored-by: Sebastian Spier <[email protected]>
@spier commited your suggestions 😇 can you review again please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a tiny something :)
Co-authored-by: Sebastian Spier <[email protected]>
Done @spier ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Should I merge? I am pretty sure @pmalirz won't object :)
I'll fix the lint issues and update the PR. I also created an issue to discuss some improvements about the lint in the project: #15 |
Thank you for your contribution @afucher! ❤️ |
Propose a pattern to create pages with curated content in other languages than english.
/content/<language>