Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page exclusive for pt-br content #14

Merged
merged 7 commits into from
May 24, 2024

Conversation

afucher
Copy link
Collaborator

@afucher afucher commented May 23, 2024

Propose a pattern to create pages with curated content in other languages than english.

  • Create folder structure to handle languages: /content/<language>
  • Add a index to all available language content (I opted to add english as an option and link to the main content, to be explicit)
  • Fix the link in the main page to the repository, it was pointing to a totally different repository (probably the one that was inspiration for this one).

@afucher afucher requested a review from pmalirz as a code owner May 23, 2024 18:06
@yuhattor
Copy link
Member

Here's my suggestion
@spier @pmalirz

  • moving file from /content/pt-br/README.md to README.pt-br.md. People will be easily find the contents.
  • Inviting @afucher and @fer-correa and Eneri to the repository and adding them as codeowners for the README.pt-br.md file

What do you think? If you can agree on that, I will ad them as codeowners

@spier
Copy link
Member

spier commented May 24, 2024

I agree, let's start with the most simple possible structure, and see how that works.
i.e. I am in favor of the solution that @yuhattor proposed 👍

@afucher
Copy link
Collaborator Author

afucher commented May 24, 2024

Done! @spier @yuhattor can you check please?

Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

left minor formatting suggestions inline

README.md Outdated Show resolved Hide resolved
README.pt-br.md Show resolved Hide resolved
@afucher
Copy link
Collaborator Author

afucher commented May 24, 2024

@spier commited your suggestions 😇 can you review again please?

Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a tiny something :)

README.pt-br.md Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Spier <[email protected]>
@afucher
Copy link
Collaborator Author

afucher commented May 24, 2024

Done @spier !

Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Should I merge? I am pretty sure @pmalirz won't object :)

@afucher afucher mentioned this pull request May 24, 2024
2 tasks
@afucher
Copy link
Collaborator Author

afucher commented May 24, 2024

I'll fix the lint issues and update the PR. I also created an issue to discuss some improvements about the lint in the project: #15

@spier spier merged commit 116f99f into InnerSourceCommons:main May 24, 2024
1 check passed
@spier
Copy link
Member

spier commented May 24, 2024

Thank you for your contribution @afucher! ❤️

@afucher afucher deleted the init-pt-br branch May 24, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants