-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fixing #521 default language issue #567
Open
yuhattor
wants to merge
4
commits into
master
Choose a base branch
from
fixing-default-language-bug
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks the following issue "Custom 404 per language" is related to this one |
…creating shared 404.html files for the wrong default language
The following pages have been updated.
# Delete unnecessary files to prevent hugo from creating shared 404.html files for the wrong default language - Temporary fix
find content -name '404.md' -not -path 'content/en/404.md' -exec rm {} +
# Build
hugo --minify
# Append language options to public/404.html - Temporary fix
sed -i 's|<option>English</option>|&<option value="/fr">Français</option><option value="/ja">Japanese</option>|g' public/404.html Google.Chrome.2023-06-19.22.05.15.Jun.19.2023.1005.PM.mp4 |
What part of the code changes accomplishes this? |
will take a look at the issue again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.