Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removes aliases from announcements #780

Conversation

andrea-kyurchiev
Copy link
Collaborator

A workaround for #521 until we find a permanent fix. Seems that this only happens if aliases are used for announcements

@andrea-kyurchiev andrea-kyurchiev requested a review from a team as a code owner May 27, 2024 05:26
@rrrutledge
Copy link
Contributor

Will this break existing links?

@andrea-kyurchiev
Copy link
Collaborator Author

Not within the website, no. Only if any of the announcements are linked anywhere external (ex. LinkedIn)

@rrrutledge
Copy link
Contributor

Current behavior when visiting a page with an alias is for the page to be displayed in English (albeit with a “zh” in the URL path). Is that correct?

@andrea-kyurchiev
Copy link
Collaborator Author

@rrrutledge yes, its the "zh" in front that changes the language

@rrrutledge
Copy link
Contributor

Thanks for looking at this, @andrea-kyurchiev.

I have to ask my question again, though, because I don’t think it’s been answered, yet.

Today, when a person visits a page alias, will they see the page rendered in English or Chinese?

@andrea-kyurchiev
Copy link
Collaborator Author

@rrrutledge the page itself will be in English as none of the announcements have a Chinese translation but the website's locale will be changed to Chinese

@rrrutledge
Copy link
Contributor

OK - got it. One more question, now. After merging this PR, if a person visits a page alias, what will they see? 404 page?

@andrea-kyurchiev
Copy link
Collaborator Author

@rrrutledge yes, I believe so

@rrrutledge
Copy link
Contributor

In that case let’s not do this change. Landing at a page with English text (albeit with Chinese locale) is a better experience than landing on a 404 page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants