BUG: Add ImageAdaptor::ComputeOffset, to fix ImageRegionIterator support#5872
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:mainfrom Mar 7, 2026
Conversation
Fixed issue InsightSoftwareConsortium#5870, "ImageAdaptor should have its own ComputeOffset, ImageRegionIterator support broken" `ImageRegionConstIterator<AdapterType>::Increment()` depends on `AdapterType::ComputeOffset`.
github-actions
bot
added
type:Bug
dzenanz
approved these changes
Mar 6, 2026
hjmjohnson
approved these changes
Mar 6, 2026
Contributor
Author
|
FYI, this triggered me to try to fix this issue: PR #5848 comment https://github.com/InsightSoftwareConsortium/ITK/pull/5848/changes#r2878841605 My attempts to replace |
hjmjohnson
merged commit 69ef176
into
InsightSoftwareConsortium:main
17 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5870, "ImageAdaptor should have its own ComputeOffset, ImageRegionIterator support broken"
ImageRegionConstIterator<AdapterType>::Increment()depends onAdapterType::ComputeOffset.