Skip to content

STYLE: Use DefaultPixelAccessor in itkImageAdaptorGTest #5913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hjmjohnson merged 1 commit into from
Mar 10, 2026
+4 −24
Merged

STYLE: Use DefaultPixelAccessor in itkImageAdaptorGTest #5913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 4 additions & 24 deletions Modules/Core/ImageAdaptors/test/itkImageAdaptorGTest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include "itkImageAdaptor.h"

#include "itkCovariantVector.h"
#include "itkDefaultPixelAccessor.h"
#include "itkImage.h"
#include "itkImageBase.h"
#include "itkImageRegionIterator.h"
Expand All @@ -32,27 +33,6 @@

namespace
{
template <typename TPixelType>
class DummyPixelAccessor
{
public:
using ExternalType = TPixelType;
using InternalType = TPixelType;

static void
Set(TPixelType & output, const TPixelType & input)
{
output = input;
}

static TPixelType
Get(const TPixelType & input)
{
return input;
}
};


template <typename T1, typename T2>
void
Expect_same_type_and_equal_value(T1 && value1, T2 && value2)
Expand Down Expand Up @@ -127,7 +107,7 @@ Expect_Transform_member_functions_return_the_same_for_an_ImageAdaptor_as_for_its
const auto ImageDimension = TImage::ImageDimension;
using IndexType = itk::Index<ImageDimension>;

const auto imageAdaptor = itk::ImageAdaptor<TImage, DummyPixelAccessor<typename TImage::PixelType>>::New();
const auto imageAdaptor = itk::ImageAdaptor<TImage, itk::DefaultPixelAccessor<typename TImage::PixelType>>::New();
imageAdaptor->SetImage(&image);

for (const auto & point :
Expand Down Expand Up @@ -197,7 +177,7 @@ TEST(ImageAdaptor, ComputeOffset)
using ImageType = itk::Image<PixelType, dimension>;

const auto image = ImageType::New();
const auto adaptor = itk::ImageAdaptor<ImageType, DummyPixelAccessor<PixelType>>::New();
const auto adaptor = itk::ImageAdaptor<ImageType, itk::DefaultPixelAccessor<PixelType>>::New();

// Use a very small image region, to speed up the unit test.
const itk::ImageRegion imageRegion{ itk::Index<dimension>::Filled(1), itk::Size<dimension>::Filled(2) };
Expand All @@ -221,7 +201,7 @@ TEST(ImageAdaptor, SupportsRegionIterator)
using ImageType = itk::Image<PixelType, dimension>;

const auto image = ImageType::New();
const auto adaptor = itk::ImageAdaptor<ImageType, DummyPixelAccessor<PixelType>>::New();
const auto adaptor = itk::ImageAdaptor<ImageType, itk::DefaultPixelAccessor<PixelType>>::New();

adaptor->SetImage(image);
adaptor->SetRegions(itk::Size<dimension>::Filled(4));
Expand Down
Loading