Convert Article, PDF, and Summary to use dataclasses#3
Merged
Conversation
jparise
force-pushed
the
dataclasses
branch
2 times, most recently
from
808dc4c to
70fcd7c
Compare
jparise
changed the title
This also changes their initialization behavior: we now use keyword arguments that map to their typed fields. This moves some of the work to the Client, but that's appropriate because it understands the shape of the response objects. This also lets us remove a number of tests cases because they were just asserting the dataclass field values we were providing.
jparise
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also changes their initialization behavior: we now use keyword arguments that map to their typed fields. This moves some of the work to the Client, but that's appropriate because it understands the shape of the response objects.
This also lets us remove a number of tests cases because they were just asserting the dataclass field values we were providing.