Add stream argument validation#1969
Merged
oleksandr-pavlyk merged 3 commits intomasterfrom Jan 16, 2025
Merged
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_448 ran successfully. |
Collaborator
antonwolfy
reviewed
Jan 15, 2025
oleksandr-pavlyk
force-pushed
the
stream-keyword-validation
branch
from
ef45728 to
df8c1f3
Compare
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_469 ran successfully. |
antonwolfy
reviewed
Jan 16, 2025
Stream keyword validation and deployment was copy-pasted in several places. Created function _stream_validate_and_use, and used it in a couple of places. This brings uniformity of error messages, and should improve coverage and maintainability.
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_470 ran successfully. |
antonwolfy
reviewed
Jan 16, 2025
antonwolfy
approved these changes
Jan 16, 2025
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @oleksandr-pavlyk, LGTM
6 tasks
antonwolfy
added a commit
to IntelPython/dpnp
that referenced
this pull request
Jan 17, 2025
…hod (#2263) The PR proposes to align `dpnp.ndarray.to_device` method with python array API and to add support of `stream` keyword argument. The tests coverage is extended to cover new argument. Previously muted array-api test is enabled back. Note, tests for `dpnp.__dlpack__` are updated due to recent changes done in [dpctl#1969](IntelPython/dpctl#1969).
github-actions bot
added a commit
to IntelPython/dpnp
that referenced
this pull request
Jan 17, 2025
…hod (#2263) The PR proposes to align `dpnp.ndarray.to_device` method with python array API and to add support of `stream` keyword argument. The tests coverage is extended to cover new argument. Previously muted array-api test is enabled back. Note, tests for `dpnp.__dlpack__` are updated due to recent changes done in [dpctl#1969](IntelPython/dpctl#1969). 6cc2348
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
streamargument is notdpctl.SyclQueue,raise TypeError