Copy from/to multidimensional buffers#1985
Merged
oleksandr-pavlyk merged 4 commits intoIntelPython:masterfrom Feb 7, 2025
Merged
Copy from/to multidimensional buffers#1985oleksandr-pavlyk merged 4 commits intoIntelPython:masterfrom
oleksandr-pavlyk merged 4 commits intoIntelPython:masterfrom
Conversation
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
sommerlukas
requested review from
ndgrigorian and
oleksandr-pavlyk
as code owners
oleksandr-pavlyk
previously approved these changes
Feb 4, 2025
Contributor
oleksandr-pavlyk
left a comment
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
Thank you for the fix @sommerlukas !
The change looks good to me, lets wait for the CI though
Collaborator
ndgrigorian
reviewed
Feb 5, 2025
ndgrigorian
previously approved these changes
Feb 5, 2025
Collaborator
ndgrigorian
left a comment
ndgrigorian
left a comment
There was a problem hiding this comment.
LGTM! Thank you @sommerlukas
Collaborator
|
Noting that the new test passes on both HIP and CUDA devices when the nd-memory-copy branch is built |
oleksandr-pavlyk
approved these changes
Feb 7, 2025
Contributor
oleksandr-pavlyk
left a comment
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
LGTM! Thank you @sommerlukas
ndgrigorian
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using typed memoryviews restricts queue
memcpyto buffers with a single dimension only.With this change, multi-dimensional buffers with contiguous layout can now be
memcpy'd.