Skip to content

Fix smart-pointer-managed USM leaks in synchronizing kernel calls#2002

Merged
ndgrigorian merged 1 commit intomasterfrom
fix-smart-ptr-memory-leaks
Feb 20, 2025
Merged

Fix smart-pointer-managed USM leaks in synchronizing kernel calls#2002
ndgrigorian merged 1 commit intomasterfrom
fix-smart-ptr-memory-leaks

Conversation

@ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Feb 20, 2025 •
edited
Loading

In blocking (i.e., synchronizing) calls in accumulators and copy to usm_ndarray from NumPy array, smart pointers were being released instead of reset without freeing underlying memory.

This PR changes these release calls to reset.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
Fix memory leaks in synchronizing kernel calls
7a2f215 
In synchronizing calls, smart pointers were being released (rather than reset)
with no call to free underlying memory, causing USM to leak
@github-actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Feb 20, 2025

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_527 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Feb 20, 2025

Coverage Status

coverage: 88.224%. remained the same
when pulling 7a2f215 on fix-smart-ptr-memory-leaks
into a34686f on master.

antonwolfy
antonwolfy approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! LGTM

@ndgrigorian ndgrigorian merged commit 0a9c725 into master Feb 20, 2025
73 of 74 checks passed
@ndgrigorian ndgrigorian deleted the fix-smart-ptr-memory-leaks branch February 20, 2025 18:23
ndgrigorian added a commit that referenced this pull request Feb 20, 2025
@ndgrigorian
Add gh-2002 to 0.19.0 changelog
fd47767
@ndgrigorian ndgrigorian mentioned this pull request Feb 20, 2025
Merged
8 tasks
ndgrigorian added a commit that referenced this pull request Feb 20, 2025
@ndgrigorian
Merge pull request #2004 from IntelPython/backport-gh-2002
933c642 
Backport gh-2002
ndgrigorian added a commit that referenced this pull request Feb 24, 2025
@ndgrigorian
Add gh-2002 to 0.19.0 changelog
6462107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian @coveralls @antonwolfy