[MAINT] Run array API conformity with 2024.12 spec #2021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2021/index.html |
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_14 ran successfully. |
ndgrigorian
force-pushed
the
experimentally-use-array-api-version-2024.12
branch
from
fc9bea6 to
015cae9
Compare
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_73 ran successfully. |
ndgrigorian
force-pushed
the
experimentally-use-array-api-version-2024.12
branch
from
015cae9 to
3ca6255
Compare
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_87 ran successfully. |
|
@antonwolfy |
array API 2024 spec requires advanced indexing with integer arrays, and when advanced indexing behavior is triggered, integral scalars are to be converted to arrays and broadcast with the other indices
this fixes cases like `x[..., arr1, int1, arr2, int2, :, int3]`, the final int will be treated as an integer instead of an array, and `arr1` through `int2` will be treated as arrays
since the index is on the host, we can raise like we normally would, which follows NumPy behavior
Reduces code duplication
Typos from advanced indexing updates
Test for the case where an basic integral index appears between two integral arrays, followed by a basic index, and then followed by `:`
0D array indices are treated as Python scalars and moved to the host when not part of other, consecutive array indices This means that 0D arrays also can't start a series of consecutive advanced indices
…en not among consecutive integer arrays
ndgrigorian
force-pushed
the
experimentally-use-array-api-version-2024.12
branch
from
3ca6255 to
8a210c0
Compare
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_132 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR experiments with running array API conformity tests with
ARRAY_API_TESTS_VERSION=2024.12