Add project root folder to include_dirs in _cython_api setup script#2147
Merged
ndgrigorian merged 1 commit intoIntelPython:masterfrom Sep 16, 2025
Merged
Add project root folder to include_dirs in _cython_api setup script#2147ndgrigorian merged 1 commit intoIntelPython:masterfrom
ndgrigorian merged 1 commit intoIntelPython:masterfrom
Conversation
sycloid
requested review from
antonwolfy,
ndgrigorian,
vlad-perevezentsev and
vtavana
as code owners
|
Can one of the admins verify this patch? |
Collaborator
Collaborator
|
@sycloid please set up pre-commit (per our contributing guide) and use it to make this commit match our Python style |
Add project root folder to include_dirs in the setup_cython_api.py so that Cython can find dpctl/__init__.pxd This resolves IntelPythongh-2146 for me locally with Cython 3.1.3
sycloid
force-pushed
the
fix-test-cython-api
branch
from
bc34f84 to
b03ce57
Compare
ndgrigorian
approved these changes
Sep 16, 2025
Collaborator
ndgrigorian
left a comment
ndgrigorian
left a comment
There was a problem hiding this comment.
LGTM! thanks again @sycloid
sycloid
added a commit
to sycloid/dpctl
that referenced
this pull request
Sep 17, 2025
Given locally non-reproducible test crashes observed in CI, say in IntelPython#2147, bump versions of TBB library and OpenCL CPU driver implementation to the one used locally (latest release of open-source DPC++).
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add project root folder to
include_dirsin the"setup_cython_api.py"so that Cython can finddpctl/__init__.pxdThis resolves gh-2146 for me locally with Cython 3.1.3