Skip to content

task: syclqueue.copy() method#2273

Open
jharlow-intel wants to merge 2 commits intomasterfrom
task/SyclQueue
Open

task: syclqueue.copy() method#2273
jharlow-intel wants to merge 2 commits intomasterfrom
task/SyclQueue

Conversation

@jharlow-intel
Copy link
Copy Markdown
Contributor

@jharlow-intel jharlow-intel commented Apr 2, 2026

This PR adds the python interface to the sycl runtimes copy methods and tests. I tried to follow the format of memcpy best I could

I used an LLM primarily to generate this, and then reviewed it and tweaked it by hand. My first time contributing a new method to DPCTL so apologies if I overlooked some obvious mistakes in it. I'm here to learn!

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 2, 2026

Coverage Status

coverage: 86.278% (+0.03%) from 86.248%
when pulling 9d2de49 on task/SyclQueue
into 067fe4c on master.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_50 ran successfully.
Passed: 1245
Failed: 43
Skipped: 89

#include <stdexcept>
#include <sycl/sycl.hpp> /* SYCL headers */
#include <utility>
#include <vector>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the LLM picked up that this should have been included in the first place for this file

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_51 ran successfully.
Passed: 1247
Failed: 44
Skipped: 89

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_52 ran successfully.
Passed: 1248
Failed: 43
Skipped: 89

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_53 ran successfully.
Passed: 1247
Failed: 44
Skipped: 89

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_50 ran successfully.
Passed: 1244
Failed: 47
Skipped: 89

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_51 ran successfully.
Passed: 1247
Failed: 44
Skipped: 89

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_52 ran successfully.
Passed: 1247
Failed: 44
Skipped: 89

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_50 ran successfully.
Passed: 1247
Failed: 44
Skipped: 89

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_51 ran successfully.
Passed: 1246
Failed: 45
Skipped: 89

@jharlow-intel
Copy link
Copy Markdown
Contributor Author

@antonwolfy @ndgrigorian @vlad-perevezentsev ready for review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_51 ran successfully.
Passed: 1247
Failed: 44
Skipped: 89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants