-
Notifications
You must be signed in to change notification settings - Fork 21
Explicit shape comparison for dpnp
and numpy
outputs
#2295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vtavana
wants to merge
3
commits into
master
Choose a base branch
from
compare-shape
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/pull/2295/index.html |
Array API standard conformance tests for dpnp=0.18.0dev1=py312he4f9c94_8 ran successfully. |
dpnp
and numpy
outputs
antonwolfy
reviewed
Feb 5, 2025
antonwolfy
reviewed
Feb 5, 2025
2badc2f
to
135df75
Compare
a47ee75
to
94c792e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test suite, the result arrays from
dpnp
andnumpy
were compared, but their shapes were not explicitly checked for equality. As a result, tests could pass even if the shapes differed, such as one being(1,)
and the other()
.This PR adds an explicit check to ensure that the output shapes of
numpy
anddpnp
match. Additionally, tests have been updated accordingly to pass with this new check.