Median 1d via sycl kernel #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

AlexanderKalistratov wants to merge 3 commits into master from median

Collaborator

AlexanderKalistratov commented Apr 15, 2025

Draft PR for median implementation.

sycl kernels added, but cleanup is needed
kernels are not used in python yet
tests need to be added

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?


          Initial commit

7ed9c7e

AlexanderKalistratov changed the title ~~Initial commit~~ Median 1d via sycl kernel

Contributor

github-actions bot commented Apr 15, 2025

View rendered docs @ https://intelpython.github.io/dpnp/pull/2423/index.html

Collaborator

coveralls commented Apr 15, 2025

coverage: 70.513% (-1.8%) from 72.271%
when pulling 7ed9c7e on median
into 4c5970b on master.

Contributor

github-actions bot commented Apr 15, 2025 •

edited

Loading

Array API standard conformance tests for dpnp=0.18.0dev1=py312he4f9c94_8 ran successfully.
Passed: 1222
Failed: 0
Skipped: 9

AlexanderKalistratov added 2 commits

April 23, 2025 16:33


          Call implementation from python

a8a93da


          Add sync

a518e0c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

antonwolfy Awaiting requested review from antonwolfy antonwolfy will be requested when the pull request is marked ready for review antonwolfy is a code owner

vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev will be requested when the pull request is marked ready for review vlad-perevezentsev is a code owner

vtavana Awaiting requested review from vtavana vtavana will be requested when the pull request is marked ready for review vtavana is a code owner

ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian will be requested when the pull request is marked ready for review ndgrigorian is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet