-
Notifications
You must be signed in to change notification settings - Fork 23
Unify dpnp public API exports by refactoring __init__.py
#2666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+145
−80
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
39d2ee9
Move array creation exports from dpnp_iface.py to __init__.py
vlad-perevezentsev 75bfb02
Move binary operations exports from dpnp_iface.py to __init__.py
vlad-perevezentsev bcb3697
Move couting function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev ca4e526
Move functional function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev 804098f
Move histogram function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev 36c9173
Move indexing function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev f20bdc5
Move linear algebra function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev bebfc84
Move logic function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev defce44
Move manipulation function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev 9914214
Move mathematical function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev c152d7b
Move nan function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev 6d58414
Move searching function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev fbb7b82
Move sorting function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev a92158a
Move statistics function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev 9c96ced
Move trigonometric function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev 490c4ef
Move window function exports from dpnp_iface.py to __init__.py
vlad-perevezentsev 68affb3
Merge master into refactor_public_api_exports
vlad-perevezentsev 47d599e
Remove wildcard import dpnp_algo in dpnp_iface.py
vlad-perevezentsev 382f144
Move dpnp_iface exports to __init__.py
vlad-perevezentsev b5d8308
Merge master into refactor_public_api_exports
vlad-perevezentsev 80ea4fb
Remove unnecessary pylint disables
vlad-perevezentsev 1ee5b5a
Return no-name-in-module pylint disable
vlad-perevezentsev 7cbc63a
Remove __all__ from dpnp_array_api_info.py
vlad-perevezentsev b8a4b73
Unify type exports in __init__.py and remove wildcard import
vlad-perevezentsev 57fb9f3
Unify byte_bounds() export in __init__.py and remove wildcard import
vlad-perevezentsev 723e2c1
Update changelog
vlad-perevezentsev 3ee2076
Apply remarks
vlad-perevezentsev ebf3431
Remove pylint no-member disable
vlad-perevezentsev a9c5398
Add explicit __all__ exports to dpnp/__init__.py
vlad-perevezentsev bcb399f
Merge master into refactor_public_api_exports
vlad-perevezentsev 1f3060e
Merge refactor_public_api_exports into clean_init_exports
vlad-perevezentsev 21f9837
Expand __all__ in relation to new changes
vlad-perevezentsev afaf007
Apply remarks
vlad-perevezentsev 244721b
Remove obsolete pre-commit disables
vlad-perevezentsev 2bbd6de
Revert E501 flake ignore
vlad-perevezentsev 7971b3b
Move is_type_supported() to dpnp_iface_random.py and remove from publ…
vlad-perevezentsev d591a57
Merge master into clean_init_exports
vlad-perevezentsev e17f107
Move flatiter import to indexing section
vlad-perevezentsev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,8 +37,6 @@ | |
|
|
||
| import dpnp | ||
|
|
||
| __all__ = ["byte_bounds"] | ||
|
|
||
|
|
||
| def byte_bounds(a): | ||
| """ | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove
"--disable=c-extension-no-member"from.pre-commit-config.yamlnow?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And E501 skipping in
.flake8There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably you meant
F403: ‘from module import *’ usedSince some files that are to be removed in the future still contain wildcard imports I would prefer not to change flake8 config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine to remove that in the follow up PR