This repository was archived by the owner on Dec 20, 2023. It is now read-only.
Removes friendlyName from payload #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clausjs
approved these changes
Feb 19, 2020
Contributor
clausjs
left a comment
clausjs
left a comment
There was a problem hiding this comment.
LGTM. @sean-ciq We should also consider removing this from the test data QA is using here: https://github.com/ChartIQ/finsemble-manual-testing/blob/master/configs/local-fdc-appd-server.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
friendlyName is not a FDC3 property. In order to avoid confusion for users using this as an example of App D, this PR removed that property.
Tested all 4 endpoints to make sure I didn't heck up anything in the JSON.