Fix inconsistency in io-sim's handling of submicrosecond delays #1757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isovector
requested review from
amesgen,
bladyjoker,
dnadales,
fraser-iohk,
geo2a,
jasagredo and
nfrisby
as code owners
dnadales
approved these changes
Nov 10, 2025
jasagredo
requested changes
Nov 24, 2025
Contributor
There was a problem hiding this comment.
Two of the three commits are empty. Squash them or remove them, please.
EDIT: also please mention that this is related to the PeerSimulator or the Genesis tests in the PR title, at the moment it sounds like you are fixing it everywhere in the code (which might be true as the diff might be the only place where it needs fixing, but still).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a workaround for input-output-hk/io-sim#232, where very small
threadDelays round down to 0 microseconds inIO, but are considered non-zero inio-sim.Before this PR, the genesis tests can (and frequently do) deadlock when run in
IO. This PR fixes the potential for deadlock.