Skip to content

Full rework of the BlockFetch logic for bulk sync mode #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 136 commits into
base: blockfetch/baseline
Choose a base branch
from
Draft

Full rework of the BlockFetch logic for bulk sync mode #4904

wants to merge 136 commits into from

Conversation

Niols
Copy link
Collaborator

@Niols Niols commented Jul 3, 2024

No description provided.

Niols added 30 commits June 12, 2024 15:34
@Niols
Split the BlockFetch.Decision module
db39d20
@Niols
Start writing a simple BlockFetch decision logic
c356465
@Niols
Note on “bulk sync”
9771ed0
@Niols
Get longest candidate
9b3693a
@Niols
Break down filterNotAlreadyFetched in two functions
5e4a665
@Niols
Break down filterNotAlreadyInFlightWithPeer in two functions
cc12e86
@Niols
More work on bulk sync block fetch
47bd5c3
@Niols
Filter plausible and in flight with other peer
1cd371e
@Niols
Yay movin' forward
18e2fed
@Niols
Choose the candidate to get and try to fetch it
837d017 
...except the fetch function is not implemented yet
@Niols
Getting there
3d71e47
@Niols
Move fetchRequestDecision to Common
86fccf6 
... but not `fetchRequestDecisions` that still belongs to the deadline
mode: the bulksync mode is only interested in deciding for one candidate.
@Niols
First implementation of a naive bulk sync decision logic
69b7c28
@Niols
Some notes here and there
d5b5fd2
@Niols
Better filtering of peers if they don't provide the fragments
bc07066
@Niols
A note
5fffd66
@Niols
Allow reading a peer queue in the consensus interface
c5c802b
@Niols
Use peer order in decision
a535930
@Niols
Keep peers order internal
e37410c
@Niols
Add action to demote the dynamo
3ac66dd
@Niols
Keep more granular decisions for each peer
9ffe465
@Niols
Documentation
db3f862
@Niols
Some minor improvements
54e6cbc
@Niols
Rewrite with new logic
32bfd08 
as discussed in the sync
@Niols
Simplify types
082fe81
@Niols
Make selectTheCandidate return a WithDeclined
60ab44b
@Niols
Make selectThePeer return a WithDeclined
24ef98c
@Niols
Use actual transformers
d56d2c5
@Niols
Remove MaybeT from WithDeclined
7ac4bb5
@Niols
Inline partitionEithersFirst
4771b82
@facundominguez facundominguez force-pushed the blockfetch/milestone-1 branch from 093b45f to 717d49f Compare July 22, 2024 21:50
facundominguez and others added 26 commits July 22, 2024 22:01
@facundominguez
Groom makeFetchRequest
ff1d5ac
@facundominguez
Revert "Note on “bulk sync”"
460d18f 
This reverts commit 9771ed0.
@facundominguez
Set the default decision loop interval to 40 ms
7686f9c
@facundominguez
Separate the decision loop interval for bulksync and deadline modes
7284bda
@facundominguez
Make the output more descriptive on failures of the BlockFetch tests
34c829f
@facundominguez
Fix typo in error message
439116a
@facundominguez
Have failing BlockFetch tests terminate
f4a335d
@facundominguez
Fix expectations of test 'static chains without overlap'
ad95337
@facundominguez
Fix expectations of test 'static chains with overlap'
178872f
@facundominguez
Refactoring: resolve declination of the candidate fragments early
38152f3
@facundominguez
Sort the peers only once in the decision logic
43b4491
@facundominguez
Don't update de peers order prematurely
f6a9152
@facundominguez
Change the current peer if it cannot provide the gross request
60ea108
@facundominguez
Put the current peer at the front of the peers order
27c819d
@facundominguez
Relax the predicates of 'static chains with/out overlap'
4373d13
@facundominguez
Rename BlockFetch tests that only test BulkSync mode
0675bfc
@facundominguez
fixup: Separate the decision loop interval for bulksync and deadline …
427c92d 
…modes
@facundominguez
Delete extract
576a425
@facundominguez
Update the current peer every time it has changed.
441d6d7
@facundominguez
Adjust documentation after putting the current peer at the front of p…
69986a2 
…eersOrder
@facundominguez
Flip calls to align peers and check starvation
9ad28ad
@facundominguez
Run the BlockFetch logic at least once every grace period
6438401
@facundominguez
Use compareCandidateChains to select a chain in BulkSync BlockFetch
6162644
@nbacquey @facundominguez
Replace custom type ListConcat with DList
45ec560
@nbacquey @facundominguez
use Seq instead of List for peersOrderAll
12a0f1f
@nbacquey @facundominguez
Replace filter by assertion when building gross request
9abfde5
@coot coot added the consensus issues related to ouroboros-consensus label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facundominguez facundominguez facundominguez left review comments

Assignees

No one assigned

Labels

consensus issues related to ouroboros-consensus Genesis

Projects

Ouroboros Network
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Niols @facundominguez @coot @nbacquey