fix: bee cage name display bug when change language - #774
Open
HowXu wants to merge 1 commit into
Open
Conversation
Author
|
@JaisDK Sorry for bothering you, If it's not too trouble, could you review this in your spare time? thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original bee cage name is from ItemTag "name", However it's hard coded, it perform wrong when you change your language and for some special configured bee in some modpacks, the name can not be saved correctly:
In first shoot, the whole name should be one language, not two.
Just change the display from name to transkey which read from a filed constructed with a normal synatx, meanwhile keep a compare and return a default, this can perform well for configurable_bee too.