Conversation
* refactor: 특정 멤버의 여행 목록 조회 시 완료되지 않은 여행만 조회하도록 조건 설정 * test: TripQueryServiceTest 여행 목록 조회 단위 테스트 수정
chaiminwoo0223
approved these changes
Oct 17, 2025
Contributor
chaiminwoo0223
left a comment
chaiminwoo0223
left a comment
There was a problem hiding this comment.
고생하셨습니다. 머지 부탁드려요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 작업 내용 및 특이사항
✅ 여행 목록 조회 리팩토링
TripQueryRepository에서 여행 목록을 조회하는 쿼리 메서드명을 특정 멤버의 완료되지 않고 삭제되지 않은 여행을 슬라이스 처리해 조회한다는 의미를 명확히 하기 위해findSliceByMemberIdAndCompletedFalseAndDeletedAtIsNull로 수정했습니다.✅ 테스트 코드 수정
TripQueryService여행 목록 조회 단위 테스트를 수정했습니다.🌱 관련 이슈
🔍 참고사항(선택)
📚 기타(선택)