Grouch UI #13
Grouch UI #13
Conversation
adithya-gv
left a comment
adithya-gv
left a comment
There was a problem hiding this comment.
some of the buttons on the mac side don't exactly render well, but functionality is all good. one suggestion i have is once the tracking request is made, perhaps have a second wait screen until the notification is made.
| class Ui(QDialog): | ||
| def __init__(self): | ||
| super(Ui, self).__init__() # Call the inherited classes __init__ method | ||
| uic.loadUi('src\qtWin.ui', self) # Load the .ui file |
There was a problem hiding this comment.
would probably need to make a second file for unix/linux because file pathing is handled differently between windows and unix/linux
There was a problem hiding this comment.
Doesn't have to be a second file. You can use Python pathlib which should handle the different path systems internally. I believe you can replace this with
uic.loadUi(Path('src/qtWin.ui'), self)That should be handled correctly regardless of OS.
JIceberg
left a comment
JIceberg
left a comment
There was a problem hiding this comment.
The window size and objects need to be dynamic sizes based on window size instead of static. Ensure the font size is also based on screen size.
| class Ui(QDialog): | ||
| def __init__(self): | ||
| super(Ui, self).__init__() # Call the inherited classes __init__ method | ||
| uic.loadUi('src\qtWin.ui', self) # Load the .ui file |
There was a problem hiding this comment.
Doesn't have to be a second file. You can use Python pathlib which should handle the different path systems internally. I believe you can replace this with
uic.loadUi(Path('src/qtWin.ui'), self)That should be handled correctly regardless of OS.
3 participants
Made a simple-ish UI using PyQt5 (and Qt Designer to design the interface) that works on top of pre-existing Grouch code, works fine on Win 10 but need to check for Win 11/MacOS/Linux. Added PyQt5 at version 5.15.4 to all requirements.txt. Basically just allows users to set term, search+add courses by CRN to a list, and then activate trackers for that full list of courses. Everything I did is in winMain.py (actual code) and qtWin.ui (behind the scenes formatting for the window created by Qt Designer).