update build to work with gradle 9.1 and Java 25 #962

wakingrufus · 2025-09-22T16:29:29Z

update build to work with gradle 9.1 and Java 25
create separate test tasks for each java version
attempt to recreate project isolation failure

Kotlin 1.7 support dropped

JLLeitschuh · 2025-09-22T20:11:13Z

plugin/settings.gradle.kts

+            Runtime::class.java
+                .let { it.getPackage().specificationVersion ?: it.getMethod("version").invoke(null).toString() }
+                .split(".")[0].toInt() <= 11


Good lord that's messy 😂

yeah, declaring a separate function doesn't work because the plugin block is evaluated before the rest of the script.

Yea... I know... Funnily enough, I've actually mucked around in that part of the Gradle code many-a-year-ago. It's an absolutely wild bit of code. 😆

wakingrufus · 2025-09-26T23:18:15Z

@JLLeitschuh would you mind updating the "required checks" to reflect the new action task names?

JLLeitschuh

Some questions

JLLeitschuh · 2025-09-30T20:36:52Z

.github/workflows/build-and-check.yml

+      - name: Restore TestKit cache
+        # Inspired by https://github.com/actions/cache/issues/432#issuecomment-740376179
+        uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 # v4.2.4
+        with:
+          path: |
+            plugin/.gradle-test-kit/caches/modules-2
+            plugin/.gradle-test-kit/caches/files-2.1
+            plugin/.gradle-test-kit/caches/metadata-2.96
+          key: gradle-wrapper-${{ hashFiles('**/gradlew') }}-${{ github.sha }}
+          restore-keys: |
+            gradle-wrapper-${{ hashFiles('**/gradlew') }}-
+            gradle-wrapper-


Did this get dropped during some of my refactors accidentally? Whoops 😬

no this is copy-pasted from another spot, b/c i had to make a separate task

JLLeitschuh · 2025-09-30T20:39:54Z

plugin/build.gradle.kts

+        named<JvmTestSuite>("test") {
+            useJUnitJupiter()
+        }
+        listOf(8, 11, 17, 21, 25) // TODO get from data feed


Get from the data feed, with a default set that automatically exist for easy checkout-and-run

the default test task runs with whatever JDK the build is running on, so that takes care of the easy checkout and run.

im not so sure we actually should get this from a data feed, given:

it doesnt change very often

I don't think there is a way to do this that wouldnt break the configuration cache

I mean, we either want to do it, or remove the TODO 😂

Is it fine to break configuration cache on CI? That doesn't seem like it's too bad IMHO

on CI, no, but it would break if for local builds as well.

yeah ill remove the TODO if we agree, I left it here for now until we make the decision

I removed the TODO

settings.gradle.kts

JLLeitschuh · 2025-10-17T18:32:13Z

would you mind updating the "required checks" to reflect the new action task names?

That's probably going to need to happen post-merge, I can always bypass the rules to let a merge happen

JLLeitschuh · 2025-10-17T18:38:28Z

plugin/build.gradle.kts

-    enabled = false
-}
-
 val ensureDependenciesAreInlined by tasks.registering {


Is this task even doing what we were thinking it was doing? Is it doing it adequately?

You said that our pom and gradle metadata dependencies were being exposed as direct dependencies, right?

I played around with it a bit, I there was nothing I could do to actually make this thing fail. I think the shadow plugin has improved to where it is harder to mess this stuff up now. So I have removed this task

JLLeitschuh

Left some review comments

create separate test tasks for each java version attempt to recreate project isolation failure create separate Gradle test task for each JVM version. these are still individually invoked by github actions matrix fix GMM and POM to properly reflect that the published Jar is a shadow jar

JLLeitschuh

LGTM! Just one question

JLLeitschuh · 2025-10-20T21:55:21Z

.github/workflows/build-and-check.yml

-          java-version: ${{ matrix.java_version }}
+          java-version: |
+            ${{ matrix.java_version }}
+            21


Isn't this already in the matrix? Do we need to add it again manually? Just trying to understand

the daemon toolchain is locked to 21 now, so we always need 21 for gradle itself. the test process is forked off of that using a project toolchain launcher, determined by the parameter we pass in (which is sourced from the matrix)

JLLeitschuh · 2025-10-22T18:57:05Z

Is this good to merge? Once I do so, I'll update the GitHub actions required cheks

wakingrufus · 2025-10-22T22:52:01Z

Is this good to merge? Once I do so, I'll update the GitHub actions required cheks

yep! Thanks

wakingrufus force-pushed the project-isolation branch 8 times, most recently from 016b252 to c5719d4 Compare September 22, 2025 19:13

JLLeitschuh reviewed Sep 22, 2025

View reviewed changes

wakingrufus force-pushed the project-isolation branch 16 times, most recently from a022e36 to 015f92c Compare September 26, 2025 22:26

wakingrufus changed the title ~~recreate project isolation failure~~ update build to work with gradle 9.1 and Java 25 Sep 26, 2025

wakingrufus force-pushed the project-isolation branch from 015f92c to eb7407a Compare September 26, 2025 23:15

wakingrufus marked this pull request as ready for review September 26, 2025 23:17

wakingrufus force-pushed the project-isolation branch from eb7407a to 35c787c Compare September 26, 2025 23:17

wakingrufus requested a review from JLLeitschuh September 26, 2025 23:18

wakingrufus force-pushed the project-isolation branch 2 times, most recently from 5524597 to 6d59364 Compare September 30, 2025 19:56

JLLeitschuh reviewed Sep 30, 2025

View reviewed changes

wakingrufus force-pushed the project-isolation branch 4 times, most recently from 0b52dec to 08695a9 Compare September 30, 2025 22:18

wakingrufus requested a review from JLLeitschuh October 1, 2025 14:27

wakingrufus force-pushed the project-isolation branch from 08695a9 to ebfd1b6 Compare October 1, 2025 14:28

wakingrufus force-pushed the project-isolation branch from ebfd1b6 to f7936d2 Compare October 17, 2025 14:22

JLLeitschuh reviewed Oct 17, 2025

View reviewed changes

wakingrufus force-pushed the project-isolation branch from f7936d2 to c03b760 Compare October 20, 2025 21:41

wakingrufus requested a review from JLLeitschuh October 20, 2025 21:43

JLLeitschuh approved these changes Oct 20, 2025

View reviewed changes

JLLeitschuh merged commit 3f138ce into main Oct 23, 2025
23 of 24 checks passed

JLLeitschuh deleted the project-isolation branch October 23, 2025 06:23

update build to work with gradle 9.1 and Java 25 #962

update build to work with gradle 9.1 and Java 25 #962

Uh oh!

Conversation

wakingrufus commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wakingrufus commented Sep 26, 2025

Uh oh!

JLLeitschuh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JLLeitschuh commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JLLeitschuh left a comment

Choose a reason for hiding this comment

Uh oh!

JLLeitschuh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wakingrufus Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JLLeitschuh commented Oct 22, 2025

Uh oh!

wakingrufus commented Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wakingrufus commented Sep 22, 2025 •

edited

Loading

JLLeitschuh commented Oct 17, 2025 •

edited

Loading

wakingrufus Oct 22, 2025 •

edited

Loading