feat: support distinctrow keyword #2238
Open
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilyOng
commented
May 12, 2025
| @@ -43,9 +44,18 @@ public void setUseUnique(boolean useUnique) { | |||
| this.useUnique = useUnique; | |||
| } | |||
|
|
|||
| public boolean isUseDistinctRow() { | |||
There was a problem hiding this comment.
Since DISTINCTROW is a synonym for DISTINCT, I re-used the existing Distinct class and only augmented it with the useDistinctRow attribute to determine the string representation of Distinct.
| @@ -3027,6 +3028,8 @@ PlainSelect PlainSelect() #PlainSelect: | |||
| [ LOOKAHEAD(2) "ON" "(" distinctOn=SelectItemsList() { plainSelect.getDistinct().setOnSelectItems(distinctOn); } ")" ] | |||
| ) | |||
| | | |||
| <K_DISTINCTROW> { Distinct distinct = new Distinct(); distinct.setUseDistinctRow(true); plainSelect.setDistinct(distinct); } | |||
There was a problem hiding this comment.
This is separate from the <K_DISTINCT> case right above, because DISTINCT ON or DISTINCTROW ON is not applicable in MySQL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
DISTINCTROWkeyword available in MySQL and MariaDB.