Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting #27

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Formatting #27

wants to merge 1 commit into from

Conversation

reubenharry
Copy link
Collaborator

A standard practice is to use an automatic code formatter when writing code. This PR has run black (one such formatter) on all the Python code. This standardizes the code, which is generally nice, with the downside that it inevitably makes a few formatting decisions that not everyone loves.

We can discuss on Monday whether to use a formatter going forward. If so, I'll automate it, so that it runs when you commit code.

@reubenharry
Copy link
Collaborator Author

The only reason I'm waiting to merge this is that it will be annoying to merge into your ensemble branch (because it will create thousands of tiny inconsequential formatting changes, and some may create conflicts with your branch). For that reason, let's do this once you merge the ensemble code into the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant