fix: Prevents concurrent alembic migrations with file-based locking #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running uvicorn with multiple workers (--workers 10), all worker
processes were attempting to run alembic migrations simultaneously,
causing race conditions and errors.
Implemented file-based locking using fcntl to ensure only one process
runs migrations while other workers wait. The lock file is created in
the system temp directory with a hash of the database URL to support
multiple databases.
Also removed the redundant global _migrations_run flag which only
prevented duplicate runs within a single process, not across multiple
worker processes.
Added test-multi-worker task to pyproject.toml for testing with 10 workers.
@krokicki