TPS: affine seeding - #104
Closed
indecisiveuser wants to merge 1 commit into
Closed
Conversation
| final Dimensions dims = viewDimensions.get( viewId ); | ||
| viewBounds.put( viewId, inverseTransformedBoundingBox( tps, dims ) ); | ||
| viewBounds.put( viewId, | ||
| inverseTransformedBoundingBox( tps, dims, approximateAffines.get( viewId ) ) ); |
Contributor
There was a problem hiding this comment.
Why do you suggest to use the approximate affines instead of the actual transform here @indecisiveuser?
Contributor
|
Hi Lila, I am confused about this one (what do you mean by "current (identity) seeding of tiles"?), I added my first comment in the code that seems to the replace the TPS transform with the approximate affine. Let's discuss it tomorrow? |
Collaborator
Author
|
Hi, to answer your questions:
|
Contributor
|
Mmmh, why? It uses the inverse of the TPS transform here: |
Contributor
|
more tomorrow :) |
Contributor
|
I do not understand the problem we have ... so it is hard to think about what the right fix is. |
This was referenced Sep 3, 2026
Collaborator
Author
|
No longer needed after #106 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR. I have been encountering errors with the current (identity) seeding of tiles, which can be upwards of 40k pixels away from the actual tile location. Seeding tiles with little split point coverage with the current affine transformations seems to help. Is this the best way of going about the issue? I'd appreciate your feedback!