Conversation
Member
|
LGTM |
Collaborator
|
also looks good to me. |
Collaborator
|
not sure if I was supposed to be the one doing the merge; I apologize if I messed that up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes JW-52979 in our internal tracker. Error is below for reference. The error is invisible to the user. It happens when clicking on a workspace in the explorer to determine if it is eligible to have the "Delete Workspace" item on its right-click menu.
In the wild, I can't reproduce this bug on command. But it's appeared several times to Mary and Nataliia. Inspection of the code reveals the likely cause: domainObject was sometimes unset before use. I fixed it and verified that the menu item does appear when it should.
@porterbot should definitely review this, as he wrote the original. David should feel free to merge if he approves.
Also @krokicki for general workstation insight, and @stuarteberg because he loves Java.
Error so you don't have to look up the issue: