Skip to content

Tasmota changes #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 700 commits into from
Closed

Tasmota changes #48

wants to merge 700 commits into from

Conversation

Jason2866
Copy link
Owner

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.


Description of Change

Please describe your proposed Pull Request and it's impact.

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

P-R-O-C-H-Y and others added 30 commits November 20, 2024 10:47
* fix(Zigbee): Add missing direction to report commands

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* feat(ota): library revision

* feat(ota): license

* feat(ota): license addtion

* feat(ota): license addition into example
…#10626)

* feat(zigbee): Add setLight APIs to manually operate lights

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* feat(matter): add new endpoint - color temperature light

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* feat(matter): add a new example for a minimum matter device
---------
…baud rate higher 230400 - checks UART Clock Source (espressif#10643)

* fix(uart): fixes issue with update baudrate higher than 250000

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…10636)

* fix(zigbee): Add connected and minor fixes, example update

* fix(example): Use correct API call for connected

* fix(zigbee): Increase timeout and add semaphore to begin

* feat(zigbee): Add option to select debug libs for zigbee

* fix(example): fix warning by double percentage symbol

* fix(example): Fix serial prints for Windows os

Co-authored-by: Rodrigo Garcia <[email protected]>

* ci(pre-commit): Apply automatic fixes

* fix(example): Fix precommit spelling

---------

Co-authored-by: Rodrigo Garcia <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* guard crypt update

* guard update crypt

* Update Updater.cpp

* revert logic to disable

* change disable logic

* formatting

* formatting

* remove trailing space
* feat(asyncudp): add all current keywords to the list

* feat(asyncudp): add license information to the source code

* feat(asyncudp): add license information to the source code

* feat(asyncudp): add license information to the source code

* feat(asyncudp): add license information to the source code

* feat(asyncudp): add license information to the source code

* feat(asyncudp): revert license information to the source code

* feat(asyncudp): revert license information to the source code

* feat(asyncudp): revert license information to the source code

* feat(asyncudp): revert license information to the source code

* feat(asyncudp): revert license information to the source code

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…ration (espressif#10651)

* fix(zigbee): Increase timeout, commision again on failure
* fix(zigbee): Update library keywords
* feat(matter): adds Matter Color Light endpoint
…or wireless network provisioning (espressif#10658)

* feat(matter): Arduino WiFi Prov example for Matter
…spressif#10657)

* feat(matter): created enhanced color light new matter endpoint and example
…n) (espressif#10662)

* feat(matter): adds new matter generic switch endpoint

* fix(matter): no need of arduino preferences here

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* BLECharacteristic::notify() optimization

GeneralUtils::hexDump() doesn't output anything if the log level is not "VERBOSE". Additionally, it is very CPU intensive, even when it doesn't output anything. So it is much better to *not* call it at all if not needed. 

In a simple program which calls BLECharacteristic::notify() every 50 ms, the performance gain of this little optimization is 37% in release mode (-O3) and 57% in debug mode. 

Of course, the "#if ARDUHAL_LOG_LEVEL >= ARDUHAL_LOG_LEVEL_VERBOSE" guard could also be put inside the GeneralUtils::hexDump() function itself. But it's better to put it here also, as it is clearer (indicating a verbose log thing) and it allows to remove the "m_value.getValue().c_str()" call, which is in itself quite CPU intensive.

* BLECharacteristic optimization

Calls to BLEUtils::buildHexData() don't output anything when the log level is not "VERBOSE" or "DEBUG". As this function is quite CPU intensive, it is better to not call it when not needed.
* feat(support): documentation adjustment
* feat(support): readme files, commentaries and examples
* fix(template): Fix Issue Report Template
-----------------------------
Co-authored-by: Lucas Saavedra Vaz <[email protected]>
…spressif#10593)

* refactor(uart): Refactor UART test to work with any number of UARTs

Co-authored-by: Rodrigo Garcia <[email protected]>

* fix(uart): Set CPU freq on ESP32

* ci(pre-commit): Apply automatic fixes

* fix(spelling): Fix codespell error

---------

Co-authored-by: Rodrigo Garcia <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…HH2 (espressif#10671)

* Added custom boards GLYPH C3, GLYPHC6 & GLYPHH2 based on ESP32C3, ESP32C6 & ESP32H2

* feat(Variants) : Added custom boards GLYPH C3, GLYPHC6 & GLYPHH2

Added custom boards variants from PCBCUPID - GLYPH C3, GLYPHC6 & GLYPHH2 based on ESP32C3, ESP32C6 & ESP32H2

* added required fix : moved the variants to end and fixed build.board

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: srini <[email protected]>
Co-authored-by: Jan Procházka <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…on for commands (espressif#10676)

* feat(zigbee): Recall bound devices after reboot

* fix(zigbee): Add missing locks + allow printBoundDevices to Serial

* fix(Zigbee): Add locks to temp sensor setReporting

* fix(Zigbee): remove unnecessary space in formatting

* fix(Zigbee): proper parameter in printBoundDevices

* feat(Zigbee): factory reset when removed from network

* fix(zigbee): Update comment

* fix(zigbee): fix serial and add missing factoryReset to example

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…#10680)

* update(hooks): Bump pre-commit hooks versions

* fix(formatting): Fix python script formatting

* fix(formatting): Fix leftover files on protected folders
…0691)

* feat(matter): creates new matter fan controller endpoint
SuGlider and others added 25 commits February 19, 2025 23:31
…essif#10988)

* fix(matter): commentaries and messages related to the factory reset

* fix(matter): commentaries and messages typo
* feat(zigbee): Add range extender device endpoint

* ci(pre-commit): Apply automatic fixes

* fix(example): Fix typo catched by precommit

---------

Co-authored-by: Me No Dev <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…ressif#10848)

* test(wokwi): Enable PSRAM test

* fix(tests): Add missing diagram for ESP32-P4

* test(wokwi): Enable GPIO test

* test(wokwi): Add I2C master test

* fix(tests): Add missing requirement and improve logging

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…rs) (espressif#10950)

* add analog sensor modules

* feat(zigbee): Add analog value, input and output support

* fix(zigbee): add missing functiong to header file

* fix(zigbee): Update log messages

* ci(pre-commit): Apply automatic fixes

* fix(example): Fix comment typo

---------

Co-authored-by: Jan Procházka <[email protected]>
Co-authored-by: Me No Dev <[email protected]>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* ci(runners): Bump runner images version

* ci(arm): Use github arm images
* update feathers3 wire1 pin definition

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Garcia <[email protected]>
* add new board

add new board

* fix(board): add LED_BUILTIN #define

---------

Co-authored-by: Rodrigo Garcia <[email protected]>
* IDF release/v5.4 bcb3c32d

* fix(zigbee): Remove the need of native ieee802154 radio

---------

Co-authored-by: Jan Procházka <[email protected]>
…rd (espressif#10947)

* Adding CYObot board - 3rd party board

1. Adding Pin Header file for CYObot to variants folder
2. Add CYObot config to boards.txt

* feat(cyobot): adding cyobot_v2_esp32s3 board

Change comments in pin header file for cyobot board

* fix(cyobot_v2_esp32s3): fix variant name

fix variant name for cyobot board

* fix(boards.txt): fix name of CYOBot board

- Change name to uppercase

* fix(CYOBot): fix boards.txt & pin_arduino.h

* fix(pins_arduino.h): capitalize name

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* ci(zigbee): Check if Zigbee is enabled for CI tests

* ci(zigbee): Fix requirements

* fix(zigbee): Use LED_BUILTIN for range extender

* fix(zigbee): Use default GPIO if LED_BUILTINnot defined
espressif#11009)

* fix(zigbee): Remove the need of native ieee802154 radio

* feat(zigbee): Add ZigbeeGateway endpoint support

* fix(zigbee): Fix TimeCluster missing status attribute

* feat(zigbee): Add new src to CMakeLists

* feaz(zigbee): Update keywords.txt with latest updates

* feat(zigbee): Add 8MB Zigbee ZCZR partitions to other socs

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Garcia <[email protected]>
…ance (espressif#11015)

* fix(zigbee): use correct carbon dioxide cluster function in setTolerance

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* optional Ethernet support (JL1101 driver added)
* esp-modem only esp32, esp32s2 and esp32s3
* remove `OpenThread`
* remove all BT BLE libraries
* remove zigbee
* remove SPIFFS
* remove Client Secure
* remove Provisioning
* remove TfLite, Insights and Rainmaker
* make GPIOViewer working see arendst/Tasmota@9696118
* remove FS log which is just littering
* fix(bt): Fix compile error on ESP32-P4

* fix(bt): Fix compile error on ESP32-P4
* test(i2c): Add test to scan bus

* test(i2c): Add scan test with wifi running

* fix(i2c): Simplify test
…spressif#11042)

* feat(matter): necessary changes to insights version for esp_matter

* feat(rainmaker): update RainMaker version to 1.5.2
Copy link

coderabbitai bot commented Mar 7, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Mar 7, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message " fix(zigbee): use correct carbon dioxide cluster function in setTolerance (#11015)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add IAS Zone Notification Message service to ZigbeeHandlers and ZigbeeEP.h (#10821)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add our new development board "cezerio mini dev ESP32C6" (#10648)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add the latest versions to issue report template":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add two more Adafruit Boards (Sparkle Motion & Sparkle Motion mini) (#10809)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Adds a Minimum Code Matter Example (#10639)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Apply suggestions from code review":
    • summary looks empty
    • type/action looks empty
  • the commit message "AsyncUdp license and keyword update (#10637)":
    • summary looks empty
    • type/action looks empty
  • the commit message "BLECharacteristic optimization (#10665)":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Bugfix/include order (#10841)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Created Zigbee Endpoint for Window Covering. (#10914)":
    • summary looks empty
    • type/action looks empty
  • the commit message "ESPmDNS: Add method for querying discovered service name (#10819)":
    • type/action should start with a lowercase letter
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "Fix HardwareSerial config (#11007)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix crash in String when using nullptr (#10971) (#10972)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix crash when using String::move on empty string (#10938) (#10945)":
    • footer's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Guard crypto parts in "Update" to save resources (#10630)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 (#10816)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 (#10873)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 083aad99":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 083aad99":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.3 9a6aba74":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.4 (#10998)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.4 e37d33cc (#10980)":
    • summary looks empty
    • type/action looks empty
  • the commit message "NetworkEvents allow stack size to be changed. (#10805)":
    • summary looks empty
    • type/action looks empty
  • the commit message "OTA Library adjust (#10627)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Remove 3rd party references in code and documentation (#10666)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Tasmota changes":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Update HTTPS certificate in BasicHttpsClient.ino (#10911)":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Update Issue-report.yml with the latest version numbers":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update README.md to add ESP-SR (#10925)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update boards.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update core version to 3.1.2":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update core version to 3.1.3":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update core version to 3.2.0":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update libraries/WebServer/src/Parsing.cpp":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update of Boards.txt & variants - Adding CYObot board - 3rd party board (#10947)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update pins_arduino.h (#11000)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Use INPUT_PULLUP instead of INPUT":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "[NetworkClient] Init members of NetworkClient":
    • summary looks empty
    • type/action looks empty
  • the commit message "add board yb_esp32s3_eth":
    • summary looks empty
    • type/action looks empty
  • the commit message "add custom boards yb_esp32s3_amp v2 & v3":
    • summary looks empty
    • type/action looks empty
  • the commit message "build(deps): bump cryptography from 43.0.1 to 44.0.1 in /tests (#10961)":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "ci(test): Fix GPIO test":
    • summary looks too short
  • the commit message "ci(test): Fix PSRAM test":
    • summary looks too short
  • the commit message "feat (Variants) Added custom boards variants GLYPH C3, GLYPHC6 & GLYPHH2 (#10671)":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "feat(LP_UART): Implements the ESP32-C6/ESP32-P4 Low Power UART as a possible HardwareSerial port (#10967)":
    • summary appears to be too long
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(Matter): Adds New Matter Humidity Sensor Endpoint (#10703)":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(Matter): Creates New Matter Fan Controller Endpoint (#10691)":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(Matter): add new MatterColorLight endpoint (#10654)":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(Zigbee): Add Zigbee Dimmable light endpoint class":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(Zigbee): Add Zigbee Dimmable light example":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(Zigbee): Add Zigbee Dimmable light to CMakeLists.txt":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(Zigbee): Add additional zigbee enabled check":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(Zigbee): Adjusted example author comment":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(Zigbee): Applied formatter + add formatter protection":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(Zigbee): Recall bounded devices after reboot + IEEE address option for commands (#10676)":
    • summary appears to be too long
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(Zigbee): Update Zigbee Dimmable light example config/define names":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(Zigbee): Update Zigbee Dimmable light example to 3.1.x features":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "feat(board): Add custom board Huidu HD-WF2/HD-WF4 - esp32-s3 HUB75 driver boards (#10779)":
    • summary appears to be too long
  • the commit message "feat(matter) adds Identification callback to all matter endpoints":
    • summary looks empty
    • type/action looks empty
  • the commit message "feat(matter): New example => Wifi Prov within Matter as alternative for wireless network provisioning (#10658)":
    • summary appears to be too long
  • the commit message "feat(matter): fixes matter temperature sensor endpoint to indicate celsius as measure unit (#10759)":
    • summary appears to be too long
  • the commit message "feat(matter):replacing code in examples and header files":
    • summary looks empty
    • type/action looks empty
  • the commit message "feat(uart): [IDF 5.3] fixes HardwareSerial::updateBaudRate() using a baud rate higher 230400 - checks UART Clock Source (#10643)":
    • summary appears to be too long
  • the commit message "feat(webserver): Middleware with default middleware for cors, authc, curl-like logging (#10750)":
    • summary appears to be too long
  • the commit message "fix ESP32-U4WDH chip detection by ESP.getChipModel() (#10696)":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix compile of P4 caused from missing ")" in debug macro (#10638)":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix(SDMMC): Remove need for BOARD_HAS_SDMMC for esp32":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "fix(SPIFFS): Use new disableWDT bool return value (#10909)":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "fix(Zigbee): Add missing direction to report commands (#10623)":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .
  • the commit message "fix(logging): incorrect FPS logging (#10921)":
    • footer's lines must not be longer than 100 characters
  • the commit message "fix(matter): ci codespell":
    • summary looks too short
  • the commit message "fix(matter): log_i() leftover":
    • summary looks too short
  • the commit message "fix(sntp): Lock / Unlock LWIP if CONFIG_LWIP_TCPIP_CORE_LOCKING is set":
    • footer must have leading blank line
  • the commit message "fix(uart): fixed esp32s2 uart ci test case (#10926)":
    • body's lines must not be longer than 100 characters
  • the commit message "fix(zigbee): Fixes of timeout, example, warnings and bounding + add a 2MB part scheme for Zigbee ED (#10817)":
    • summary appears to be too long
  • the commit message "improving logging message while waiting for WiFi (#10739)":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 250 commits (simplifying branch history).
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.
Messages
📖 This PR seems to be quite large (total lines of code: 80804), you might consider splitting it into smaller PRs

👋 Hello Jason2866, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 61a12ee

@Jason2866 Jason2866 closed this Mar 7, 2025
@Jason2866 Jason2866 deleted the merge branch March 7, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.