You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Proposed change allows specifying multiple root urls for easy app localization.
Additional root urls keys in settings.plist should specify language two-letter code capitalized as following "urlEN", "urlFR", "urlNL".
Upon launch app will iterate over preferred device localizations and will try to find and assign a corresponding localized root url. If no corresponding localized urls found it will use the default "url" key value.
Addresses issue #73
Thanks for the pull request and the idea. This inspired me to think about the problem a bit more, and I think we need to approach this from a deeper level, otherwise we will have to come up with ad hoc approaches every time we come across obstacles like this.
So my idea is two parts:
instead of having multiple urls, support an href attribute on the settings.plist file, which is a dictionary, and is the same href object we use all across the app. In fact we use this scheme for opening the app via url scheme support url scheme #10
set $env.locale global variable with the current device's locale.
When we compose these two together, we can open a home href which is relevant to the current user. The resulting settings.plist may look like this:
Let me know what you think, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change allows specifying multiple root urls for easy app localization.
Additional root urls keys in settings.plist should specify language two-letter code capitalized as following "urlEN", "urlFR", "urlNL".
Upon launch app will iterate over preferred device localizations and will try to find and assign a corresponding localized root url. If no corresponding localized urls found it will use the default "url" key value.
Addresses issue #73