Update Ecobee definitions#548
Conversation
…n for scheduled event time
1c9e4fd to
2a1fbc1
Compare
|
Please explain the history and how the the existing ones were incorrect |
|
@bdraco I don't understand how I can explain the history, I didn't create the first version. The diff shows how they were swapped. |
Unfortunately without understanding why they were set to the UUIDs currently in use, I can't merge this PR because I don't know if its going to break older/different models. |
|
@Jc2k When you bulk introduced these IDs 4 years ago, do you remember where you got them? And certain that they were all set correct? i'd wouldn't be able to answer this if it was me, 4 years is a long time @bdraco I understand what your trying to maintain with that position, it is true that my device is newer than 4 years old; but in the realm of known knowns, known unknowns, and unknown unknowns, these are the facts
Therefore the risk you are trying to protect is a cohort of past units (less than present and future units) that is not connected to the internet from being affected by a software patch to a system on the same network, that is connected to the internet. That is to say, if the both the old and new versions are correct in their place in time, updating this to reflect the current version would not break those on the old version because those networks would still be on the old versions together; All of which assumes that the old version is correct which is a known unknown. |
This pull request updates and expands the Ecobee-specific characteristic definitions in
characteristic_types.py. The main changes include correcting UUID assignments for several thermostat characteristics, improving documentation for scheduled change time handling, and adding new characteristics for equipment status and SmartSensor data.Updates to Ecobee characteristic UUIDs and documentation:
VENDOR_ECOBEE_NEXT_SCHEDULED_CHANGE_TIME, including details on value formats, meaning, and correct write behavior for timed holds.New Ecobee characteristic definitions: